tomee-catalina leaves open streams

[Svetlin Zarev <sv...@gmail.com>]

Hi,

TomcatWebappDeployer::deployWebApps() does not close the InputStream to the
context.xml it opens.It opens the stream on line 462 or 471 (branch 7.0.1)
, an uses it only to check if it's null on line 500 without ever reading
it.

Leaving the stream open may cause application undeployment issues, because
the users will not be able to delete the WAR/or the context.xml from the FS
on operation systems like windows that lock the file if there are open
handles to it.

Kind regards,
Svetlin

Re: tomee-catalina leaves open streams

[Romain Manni-Bucau <rm...@gmail.com>]

Hello Svetlin,

good catch, opened https://issues.apache.org/jira/browse/TOMEE-1862


Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>

2016-07-08 13:19 GMT+02:00 Svetlin Zarev <sv...@gmail.com>:

> Hi,
>
> TomcatWebappDeployer::deployWebApps() does not close the InputStream to the
> context.xml it opens.It opens the stream on line 462 or 471 (branch 7.0.1)
> , an uses it only to check if it's null on line 500 without ever reading
> it.
>
> Leaving the stream open may cause application undeployment issues, because
> the users will not be able to delete the WAR/or the context.xml from the FS
> on operation systems like windows that lock the file if there are open
> handles to it.
>
> Kind regards,
> Svetlin
>