[jira] [Commented] (TS-3347) make ink_assert a no-op in release builds

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560147#comment-14560147 ] 

Leif Hedstrom commented on TS-3347:
-----------------------------------

Sounds like we should:

1) Either un-assert or ink_release_assert() the cases where we still have side effects on the assert.  I'm ok either way, I think I'd slightly prefer to not have side-effects ink_release_assert(), but I care more that we're consistent.

2) Change ink_assert() to be a no-op in release builds.

> make ink_assert a no-op in release builds
> -----------------------------------------
>
>                 Key: TS-3347
>                 URL: https://issues.apache.org/jira/browse/TS-3347
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sudheer Vinukonda
>            Assignee: Alan M. Carroll
>             Fix For: 6.0.0
>
>
> ink_assert() is expected to be enabled only in DEBUG builds. However, the current definition of ink_assert() for non-DEBUG (release) builds, still evaluates the expression passed to it, which seems totally unnecessary. Opening this jira to make ink_assert() a complete no-op for non-DEBUG release builds. Along with the change of definition, need to scan the entire TS code to fix the code that relies on the expression evaluated in the ink_assert() accordingly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)