[jira] [Updated] (CRUNCH-356) Replace deprecated Closeables.closeQuietly with explicit IOException handling

["John Leacox (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CRUNCH-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Leacox updated CRUNCH-356:
-------------------------------
    Attachment: CRUNCH-356.patch

Here is an updated patch for the latest code in master that also removes a call to Closeables.closeQuietly in a newer class that didn't exist at the time this was originally logged.

In addition to this change, I'm wondering if there would be any interest in changing the Guava dependency of crunch to be repackaged as to avoid version conflicts with other projects. Guava 11 is 2011 and Guava 19 is currently in a release candidate status. Since Guava makes non-passive changes (e.g. removes deprecated items 2 releases after deprecation) this large version discrepancy is going to be increasingly likely to cause issues with consumers of crunch. If there is interest in repacking Guava I can log a separate jira and do that work.

> Replace deprecated Closeables.closeQuietly with explicit IOException handling
> -----------------------------------------------------------------------------
>
>                 Key: CRUNCH-356
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-356
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>            Reporter: John Leacox
>            Assignee: Josh Wills
>            Priority: Minor
>         Attachments: CRUNCH-356.patch, CRUNCH-356.patch, patch.diff, patch2.diff
>
>
> Closeables.closeQuietly was deprecated in Guava 13 and removed in Guava 16. If a consumer of crunch-core is using Guava 16+ a NoSuchMethodError could occur where Closeables.closeQuietly is being used.
> Uses of Closeable.closeQuietly should be replaced with explicit handling of IOException with logging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)