You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/15 10:55:07 UTC
[GitHub] [incubator-nuttx] raiden00pl opened a new pull request, #6858: steval-eth001v: add FOC examples
raiden00pl opened a new pull request, #6858:
URL: https://github.com/apache/incubator-nuttx/pull/6858
## Summary
steval-eth001v: add FOC examples
depends on https://github.com/apache/incubator-nuttx/pull/6811
## Impact
None
## Testing
examples/foc (float and fixed16 options)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6858: steval-eth001v1: add FOC examples
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6858:
URL: https://github.com/apache/incubator-nuttx/pull/6858#discussion_r946667805
##########
boards/arm/stm32f7/steval-eth001v1/include/board.h:
##########
@@ -35,7 +35,7 @@
* Pre-processor Definitions
****************************************************************************/
-/* Clocking */
+/* Clocking *****************************************************************/
Review Comment:
But it's common to use the style too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6858: steval-eth001v1: add FOC examples
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6858:
URL: https://github.com/apache/incubator-nuttx/pull/6858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6858: steval-eth001v1: add FOC examples
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6858:
URL: https://github.com/apache/incubator-nuttx/pull/6858#issuecomment-1216066687
@raiden00pl some build error need to fix before merge:
https://github.com/apache/incubator-nuttx/runs/7839035478?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6858: steval-eth001v1: add FOC examples
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6858:
URL: https://github.com/apache/incubator-nuttx/pull/6858#discussion_r946691899
##########
boards/arm/stm32f7/steval-eth001v1/include/board.h:
##########
@@ -35,7 +35,7 @@
* Pre-processor Definitions
****************************************************************************/
-/* Clocking */
+/* Clocking *****************************************************************/
Review Comment:
Sure. No objections!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6858: steval-eth001v1: add FOC examples
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6858:
URL: https://github.com/apache/incubator-nuttx/pull/6858#discussion_r946566194
##########
boards/arm/stm32f7/steval-eth001v1/include/board.h:
##########
@@ -35,7 +35,7 @@
* Pre-processor Definitions
****************************************************************************/
-/* Clocking */
+/* Clocking *****************************************************************/
Review Comment:
IMO this is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org