You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/07 13:08:37 UTC

[GitHub] [flink] dawidwys opened a new pull request #14324: [FLINK-20517] Disallow operators with mixed key/non-keyed inputs with BATCH state backend

dawidwys opened a new pull request #14324:
URL: https://github.com/apache/flink/pull/14324


   ## What is the purpose of the change
   
   Using the batch state backend requires that the inputs are sorted by a key. Right now when sorting, we sort either all of the inputs or none. It is because we expect that the same key is consumed from all inputs at the same time.
   
   We throw an exception if such a combination is used.
   
   ## Verifying this change
   
   Added tests:
   * `org.apache.flink.streaming.api.graph.StreamGraphGeneratorBatchExecutionTest#testMixingKeyedAndNonKeyedInputInBatchMode`
   * `org.apache.flink.streaming.api.graph.StreamGraphGeneratorBatchExecutionTest#testMixingKeyedAndNonKeyedInputsInBatchMode`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) **Should we add it to the docs in the Considerations on "Writing Custom Operators"?**
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14324: [FLINK-20517] Disallow operators with mixed key/non-keyed inputs with BATCH state backend

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14324:
URL: https://github.com/apache/flink/pull/14324#issuecomment-739909560


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4a290f27e79ad0fba20059f26147900660f4f834 (Mon Dec 07 13:12:00 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14324: [FLINK-20517] Disallow operators with mixed key/non-keyed inputs with BATCH state backend

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14324:
URL: https://github.com/apache/flink/pull/14324#issuecomment-739909560


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4a290f27e79ad0fba20059f26147900660f4f834 (Fri May 28 07:00:24 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #14324: [FLINK-20517] Disallow operators with mixed key/non-keyed inputs with BATCH state backend

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #14324:
URL: https://github.com/apache/flink/pull/14324#issuecomment-754107627


   superseded by https://github.com/apache/flink/pull/14312


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14324: [FLINK-20517] Disallow operators with mixed key/non-keyed inputs with BATCH state backend

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14324:
URL: https://github.com/apache/flink/pull/14324#issuecomment-739917080


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4a290f27e79ad0fba20059f26147900660f4f834",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10589",
       "triggerID" : "4a290f27e79ad0fba20059f26147900660f4f834",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4a290f27e79ad0fba20059f26147900660f4f834 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10589) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14324: [FLINK-20517] Disallow operators with mixed key/non-keyed inputs with BATCH state backend

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14324:
URL: https://github.com/apache/flink/pull/14324#issuecomment-739917080


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4a290f27e79ad0fba20059f26147900660f4f834",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a290f27e79ad0fba20059f26147900660f4f834",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4a290f27e79ad0fba20059f26147900660f4f834 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14324: [FLINK-20517] Disallow operators with mixed key/non-keyed inputs with BATCH state backend

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14324:
URL: https://github.com/apache/flink/pull/14324#issuecomment-739917080


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4a290f27e79ad0fba20059f26147900660f4f834",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10589",
       "triggerID" : "4a290f27e79ad0fba20059f26147900660f4f834",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4a290f27e79ad0fba20059f26147900660f4f834 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10589) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha closed pull request #14324: [FLINK-20517] Disallow operators with mixed key/non-keyed inputs with BATCH state backend

Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #14324:
URL: https://github.com/apache/flink/pull/14324


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org