svn commit: r1033183 - in /hive/trunk: CHANGES.txt ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTF.java

[jv...@apache.org]

Author: jvs
Date: Tue Nov  9 19:57:52 2010
New Revision: 1033183

URL: http://svn.apache.org/viewvc?rev=1033183&view=rev
Log:
HIVE-1777 Outdated comments for GenericUDTF.close()
(Paul Yang via jvs)


Modified:
    hive/trunk/CHANGES.txt
    hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTF.java

Modified: hive/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hive/trunk/CHANGES.txt?rev=1033183&r1=1033182&r2=1033183&view=diff
==============================================================================
--- hive/trunk/CHANGES.txt (original)
+++ hive/trunk/CHANGES.txt Tue Nov  9 19:57:52 2010
@@ -461,6 +461,9 @@ Trunk -  Unreleased
     HIVE-1774 Bug in test merge_dynamic_partition.q
     (He Yongqiang via namit)
 
+    HIVE-1777 Outdated comments for GenericUDTF.close()
+    (Paul Yang via jvs)
+
   TESTS
 
     HIVE-1464. improve  test query performance

Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTF.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTF.java?rev=1033183&r1=1033182&r2=1033183&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTF.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTF.java Tue Nov  9 19:57:52 2010
@@ -25,7 +25,7 @@ import org.apache.hadoop.hive.serde2.obj
 
 /**
  * A Generic User-defined Table Generating Function (UDTF)
- * 
+ *
  * Generates a variable number of output rows for a single input row. Useful for
  * explode(array)...
  */
@@ -35,7 +35,7 @@ public abstract class GenericUDTF {
 
   /**
    * Initialize this GenericUDTF. This will be called only once per instance.
-   * 
+   *
    * @param args
    *          An array of ObjectInspectors for the arguments
    * @return A StructObjectInspector for output. The output struct represents a
@@ -48,16 +48,15 @@ public abstract class GenericUDTF {
 
   /**
    * Give a set of arguments for the UDTF to process.
-   * 
+   *
    * @param o
    *          object array of arguments
    */
   public abstract void process(Object[] args) throws HiveException;
 
   /**
-   * Called to notify the UDTF that there are no more rows to process. Note that
-   * forward() should not be called in this function. Only clean up code should
-   * be run.
+   * Called to notify the UDTF that there are no more rows to process.
+   * Clean up code or additional forward() calls can be made here.
    */
   public abstract void close() throws HiveException;
 
@@ -65,7 +64,7 @@ public abstract class GenericUDTF {
    * Associates a collector with this UDTF. Can't be specified in the
    * constructor as the UDTF may be initialized before the collector has been
    * constructed.
-   * 
+   *
    * @param collector
    */
   public final void setCollector(Collector collector) {
@@ -74,7 +73,7 @@ public abstract class GenericUDTF {
 
   /**
    * Passes an output row to the collector.
-   * 
+   *
    * @param o
    * @throws HiveException
    */