You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/23 10:15:45 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request #395: Use arrow-rs from crates.io

alamb opened a new pull request #395:
URL: https://github.com/apache/arrow-datafusion/pull/395


   # Which issue does this PR close?
   
   
   
   Closes https://github.com/apache/arrow-datafusion/issues/393
   
    # Rationale for this change
   
   Currently datafusion relies on a git sha of the arrow-rs crate. Historically this was required to get updates on a more frequent basis than every quarter when Arrow did major releases. With https://github.com/apache/arrow-rs/issues/292 we are implementing biweekly arrow releases.
   
   This also means prior to this PR that any project that uses datafusion and arrow together requires pinning arrow-rs to the exact same gitsha. 
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   Pin to `arrow-rs` "version 4.0"
   
   However, given the way cargo interprets versions, this (somewhat confusingly) means the latest "4.x" release.
   
   You can see that 4.1 (the most recently released version of arrow-rs) is used by doing something like
   
   ```
   cargo update
   cargo tree | grep arrow
   ...
   β”œβ”€β”€ arrow v4.1.0 (*)
   ...
   ```
   
   # Are there any user-facing changes?
   Yes -- the version of arrow-rs used by dependent projects needs to be updated to be 4.0 (or some variant) as well.  However, this is no different than what has happened previously when we updated the git sha (dependent crates needed to follow the sha exactly). 
   
   This should make future datafusion upgrades easier as arrow dependent versions will only need to be updated on major releases, not each datafusion release
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] Dandandan merged pull request #395: Use 4.x arrow-rs from crates.io rather than git sha

Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #395:
URL: https://github.com/apache/arrow-datafusion/pull/395


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] alamb commented on pull request #395: Use 4.x arrow-rs from crates.io rather than git sha

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #395:
URL: https://github.com/apache/arrow-datafusion/pull/395#issuecomment-847027217


   πŸŽ‰ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #395: Use 4.x arrow-rs from crates.io rather than git sha

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #395:
URL: https://github.com/apache/arrow-datafusion/pull/395#issuecomment-846540823


   # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/395?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#395](https://codecov.io/gh/apache/arrow-datafusion/pull/395?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f1cff7) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/9eca3291ce38554042ee4441b118d8b231f3d4a7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9eca329) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-datafusion/pull/395/graphs/tree.svg?width=650&height=150&src=pr&token=JXwWBKD3D9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-datafusion/pull/395?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #395   +/-   ##
   =======================================
     Coverage   74.94%   74.94%           
   =======================================
     Files         146      146           
     Lines       24314    24314           
   =======================================
     Hits        18221    18221           
     Misses       6093     6093           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/395?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/395?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9eca329...7f1cff7](https://codecov.io/gh/apache/arrow-datafusion/pull/395?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org