You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/22 17:50:56 UTC

[GitHub] [beam] lukecwik commented on pull request #21964: Making gcpTempLocation default tolerates double slash

lukecwik commented on PR #21964:
URL: https://github.com/apache/beam/pull/21964#issuecomment-1163434136

   I don't think we want to change the path for users but instead fix-up all our path creation logic to use ResourceId.resolve() instead of raw string concatenation.
   
   For example:
   https://github.com/apache/beam/blob/04f49848d4b037a5935036927e54c8eb8ed8c361/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaUpdateOptionsIT.java#L141
   
   Should be swapped to:
   ```
   options.setTempLocation(FileSystems.matchNewResource(options.getTempRoot()).resolve("bq_it_temp", StandardResolveOptions.RESOLVE_DIRECTORY).toString());
   ```
   
   See:
   https://github.com/apache/beam/blob/45bebebdafe7c8df707259ca11c5633aebdb3933/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java#L586


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org