You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/08/09 11:56:29 UTC

[PR] chore(amber): remove the unused ElidableStatement [texera]

aglinxinyuan opened a new pull request, #7451:
URL: https://github.com/apache/texera/pull/7451

   ### What changes were proposed in this PR?
   
   Deletes `ElidableStatement`, which has no caller and whose mechanism is not configured anywhere in the build. Pure deletion, no behaviour change: **−175 lines**.
   
   | Removed | Lines | Why it is dead |
   | --- | ---: | --- |
   | `engine/common/ElidableStatement.scala` | 34 | no caller; no `-Xelide-below` in any `build.sbt` |
   | `engine/common/ElidableStatementSpec.scala` | 141 | covers only the above |
   
   The object wraps statements in `scala.annotation.elidable` so they can be compiled out below a threshold. That threshold comes from the `-Xelide-below` scalac option, which appears in **no** `build.sbt` in this repo — so the wrapper had no effect even in principle. A case-insensitive search for `elidable` across all Scala and sbt sources returns only these two files.
   
   > Reviewer note: it acquired unit tests during the 2026 coverage work, which is why it currently looks live. The spec covers this object and nothing else, so it goes with it.
   
   Split out of #7447, which originally bundled four unrelated removals.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7448
   
   ### How was this PR tested?
   
   Existing tests only — this PR adds none, since it removes code and the spec that covered it.
   
   Locally, from the repo root with Java 17:
   
   - `sbt "WorkflowExecutionService/Test/compile"` — success.
   
   Verification, re-runnable by a reviewer:
   
   ```
   git grep -in elidable          # only the two deleted files
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore(amber): remove the unused ElidableStatement [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7451:
URL: https://github.com/apache/texera/pull/7451#issuecomment-5231423300

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7451?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 85.32%. Comparing base ([`e03d971`](https://app.codecov.io/gh/apache/texera/commit/e03d97108ddd47befc78a87f467f781dd50a56e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fcadde7`](https://app.codecov.io/gh/apache/texera/commit/fcadde736b79c4c595fad060a62f026ad68434a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #7451      +/-   ##
   ============================================
   - Coverage     85.32%   85.32%   -0.01%     
   + Complexity     4151     4149       -2     
   ============================================
     Files          1169     1168       -1     
     Lines         46740    46739       -1     
     Branches       5202     5202              
   ============================================
   - Hits          39882    39880       -2     
   + Misses         5148     5147       -1     
   - Partials       1710     1712       +2     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/7451/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [e03d971](https://app.codecov.io/gh/apache/texera/commit/e03d97108ddd47befc78a87f467f781dd50a56e6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/7451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.50% <ø> (ø)` | | Carriedforward from [e03d971](https://app.codecov.io/gh/apache/texera/commit/e03d97108ddd47befc78a87f467f781dd50a56e6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/7451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.88% <ø> (-0.01%)` | :arrow_down: | |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.72% <ø> (ø)` | | Carriedforward from [e03d971](https://app.codecov.io/gh/apache/texera/commit/e03d97108ddd47befc78a87f467f781dd50a56e6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/7451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.97% <ø> (ø)` | | Carriedforward from [e03d971](https://app.codecov.io/gh/apache/texera/commit/e03d97108ddd47befc78a87f467f781dd50a56e6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/7451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.05% <ø> (ø)` | | Carriedforward from [e03d971](https://app.codecov.io/gh/apache/texera/commit/e03d97108ddd47befc78a87f467f781dd50a56e6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/7451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.85% <ø> (ø)` | | Carriedforward from [e03d971](https://app.codecov.io/gh/apache/texera/commit/e03d97108ddd47befc78a87f467f781dd50a56e6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.89% <ø> (ø)` | | Carriedforward from [e03d971](https://app.codecov.io/gh/apache/texera/commit/e03d97108ddd47befc78a87f467f781dd50a56e6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/7451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.51% <ø> (ø)` | | Carriedforward from [e03d971](https://app.codecov.io/gh/apache/texera/commit/e03d97108ddd47befc78a87f467f781dd50a56e6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.31% <ø> (ø)` | | Carriedforward from [e03d971](https://app.codecov.io/gh/apache/texera/commit/e03d97108ddd47befc78a87f467f781dd50a56e6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7451?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore(amber): remove the unused ElidableStatement [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #7451:
URL: https://github.com/apache/texera/pull/7451


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore(amber): remove the unused ElidableStatement [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #7451:
URL: https://github.com/apache/texera/pull/7451#issuecomment-5311063996

   Thanks @Yicong-Huang — you're right, and the trace is exact. `git grep -n Xelide -- '*.sbt'` gives sixteen modules at `WARNING` (900), with all four wrappers below it (`FINEST` 300, `FINER` 400, `FINE` 500, `INFO` 800), so the elision was live the whole time. I grepped for `elidable` and never for `elide`, so I missed the flag.
   
   The description and #7448 now rest on the sufficient ground — no caller. `git grep -in elidable` is empty at the head, so nothing is left dangling.
   
   On the advisory: agreed. `amber/build.sbt` even carries a `// to turn on, use: INFO` comment that refers to nothing once this lands. Filed as #7706 rather than widening this PR, since it's sixteen build files. Noted there that `assert`/`assume` are `@elidable(ASSERTION)` = 2000, above `WARNING`, and scalac elides nothing when the flag is absent — so dropping it is a genuine no-op.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore(amber): remove the unused ElidableStatement [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7451:
URL: https://github.com/apache/texera/pull/7451#issuecomment-5231412381

   <!-- texera-benchmarks-comment -->
   ## ⚠️ Benchmark changes need a look
   
   🟢 4 better · 🔴 1 worse · ⚪ 10 noise (<±5%) · 0 without baseline
   
   > Compared against main `e03d971` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
   
   [Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/31312034188)
   
   | | config | throughput | MB/s | latency | max Δ latest / 7d |
   |---|---|---:|---:|---:|---:|
   | 🔴 | bs=10 sw=10 sl=64 | 429 | 0.262 | 22,854/31,269/31,269 us | 🔴 +22.1% / 🔴 +94.0% |
   | 🟢 | bs=100 sw=10 sl=64 | 948 | 0.578 | 104,313/125,771/125,771 us | 🟢 -17.2% / 🔴 +13.1% |
   | ⚪ | bs=1000 sw=10 sl=64 | 1,110 | 0.677 | 895,992/984,290/984,290 us | ⚪ within ±5% / 🟢 +12.8% |
   
   <details><summary>Baseline details</summary>
   
   Latest main `e03d971` from same runner
   
   | config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
   |---|---|---:|---:|---:|---:|---:|
   | bs=10 sw=10 sl=64 | throughput | 429 tuples/sec | 442 tuples/sec | 752.25 tuples/sec | -2.9% | -43.0% |
   | bs=10 sw=10 sl=64 | MB/s | 0.262 MB/s | 0.27 MB/s | 0.459 MB/s | -3.0% | -42.9% |
   | bs=10 sw=10 sl=64 | p50 | 22,854 us | 18,712 us | 13,006 us | +22.1% | +75.7% |
   | bs=10 sw=10 sl=64 | p95 | 31,269 us | 37,382 us | 16,117 us | -16.4% | +94.0% |
   | bs=10 sw=10 sl=64 | p99 | 31,269 us | 37,382 us | 19,286 us | -16.4% | +62.1% |
   | bs=100 sw=10 sl=64 | throughput | 948 tuples/sec | 973 tuples/sec | 953.66 tuples/sec | -2.6% | -0.6% |
   | bs=100 sw=10 sl=64 | MB/s | 0.578 MB/s | 0.594 MB/s | 0.582 MB/s | -2.7% | -0.7% |
   | bs=100 sw=10 sl=64 | p50 | 104,313 us | 99,986 us | 105,130 us | +4.3% | -0.8% |
   | bs=100 sw=10 sl=64 | p95 | 125,771 us | 151,855 us | 111,226 us | -17.2% | +13.1% |
   | bs=100 sw=10 sl=64 | p99 | 125,771 us | 151,855 us | 121,065 us | -17.2% | +3.9% |
   | bs=1000 sw=10 sl=64 | throughput | 1,110 tuples/sec | 1,140 tuples/sec | 984.25 tuples/sec | -2.6% | +12.8% |
   | bs=1000 sw=10 sl=64 | MB/s | 0.677 MB/s | 0.696 MB/s | 0.601 MB/s | -2.7% | +12.7% |
   | bs=1000 sw=10 sl=64 | p50 | 895,992 us | 868,196 us | 1,024,295 us | +3.2% | -12.5% |
   | bs=1000 sw=10 sl=64 | p95 | 984,290 us | 945,887 us | 1,062,710 us | +4.1% | -7.4% |
   | bs=1000 sw=10 sl=64 | p99 | 984,290 us | 945,887 us | 1,095,400 us | +4.1% | -10.1% |
   
   </details>
   
   <details><summary>Raw CSV</summary>
   
   ```csv
   config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
   0,10,10,64,20,465.99,200,128000,429,0.262,22853.77,31269.09,31269.09
   1,100,10,64,20,2110.69,2000,1280000,948,0.578,104312.74,125770.80,125770.80
   2,1000,10,64,20,18020.52,20000,12800000,1110,0.677,895991.78,984290.20,984290.20
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore(amber): remove the unused ElidableStatement [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7451:
URL: https://github.com/apache/texera/pull/7451#issuecomment-5231390508

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - No candidates found from `git blame` history.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore(amber): remove the unused ElidableStatement [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #7451:
URL: https://github.com/apache/texera/pull/7451#issuecomment-5460499029

   Addressed the remaining advisory: the PR body now states the elision configuration and follow-up scope as present facts, removes the review-history wording, and uses \git grep -in elide\ for the rerunnable verification. No source change was needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org