[GitHub] [hbase] bharathv commented on a change in pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

[GitBox <gi...@apache.org>]

bharathv commented on a change in pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#discussion_r599125786



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java
##########
@@ -159,7 +159,7 @@ public void tearDownAfterMethod() throws Exception {
     int missing = NUM_SLAVES_BASE - getNumServers();
     LOG.info("Restoring servers: " + missing);
     for (int i = 0; i < missing; i++) {
-      ((MiniHBaseCluster) CLUSTER).startRegionServer();
+      ((MiniHBaseCluster) CLUSTER).startRegionServerAndWait(2000);

Review comment:
       I believe there was a test for this in the first version of the patch thats now been deleted. Do we need one for this patch?

##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
##########
@@ -176,7 +176,7 @@ private void testSanity(final String testName) throws Exception {
   @Test
   public void testRegionAssignmentAfterMasterRecoveryDueToZKExpiry() throws Exception {
     MiniHBaseCluster cluster = TEST_UTIL.getHBaseCluster();
-    cluster.startRegionServer();
+    cluster.startRegionServerAndWait(2000);

Review comment:
       I'm curious why these are needed in multiple places, hardcoding makes these tests flaky?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org