[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

["David Reiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623769#action_12623769 ] 

David Reiss commented on THRIFT-105:
------------------------------------

I'd prefer if Ben could review this since he wrote the original, but I have a few comments.

Does this test code actually test the behavior of the patch?
What was wrong with self.__class__ ?
PyInt_AsLong returns a long, not a ssize_t.


> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.