You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Sun-GLiang (via GitHub)" <gi...@apache.org> on 2026/08/21 02:05:24 UTC
Re: [PR] test(runtime-host): guard v0.1.11 handshake compatibility [maka]
Sun-GLiang commented on code in PR #3322:
URL: https://github.com/apache/maka/pull/3322#discussion_r3826740292
##########
packages/runtime-host/src/client/connection.ts:
##########
@@ -1405,10 +1394,9 @@ async function exchangeRuntimeHostHandshake(
| { kind: 'draining' }
> {
const helloProtocol = input.helloProtocol ?? input.protocol;
- const hello: LegacySurfaceClientHello = {
+ const hello: ClientHello = {
Review Comment:
Confirmed against tagged v0.1.11 (commit a3c4d0b2a6ca0c87bebebff135d40017558ae5b8): its epoch-25 decoder calls requireSurface before Host admission, so the removal was unsafe. Commit 664422579 restores the private `surface: "desktop"` sentinel, reverts the unsupported epoch-30 removal claim, and adds a frozen v0.1.11 decoder/admission regression that proves the raw hello reaches structured `incompatible`. The CLI guidance test is now pinned to epoch 25. Runtime Host (1037/1037), CLI (336/336), typecheck, lint, format, and diff-check pass. The PR no longer closes #3297; that issue remains open until its release-support gate is satisfied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org