You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by anilkumar gingade <ag...@pivotal.io> on 2016/03/18 22:14:50 UTC
Review Request 45048: GEODE-559: CI Failure:
ClientInterestNotifyDUnitTest.testInterestNotify failed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45048/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, nabarun nag, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
Test issue. Before validation test checks to see if the events are drained on the server side, but doesn't count for time taken to receive the event on client side and invoke its cache listener. Based on the machine speed and thread invocation timing, this test can intermediately fail.
Added wait logic at client side CacheListener.
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientInterestNotifyDUnitTest.java 1559506d068fe03f4f46de67abeab147ce08cf4a
Diff: https://reviews.apache.org/r/45048/diff/
Testing
-------
Run the test by simulating the problem (using thread and sleep) and validated test working as expected.
Thanks,
anilkumar gingade
Re: Review Request 45048: GEODE-559: CI Failure:
ClientInterestNotifyDUnitTest.testInterestNotify failed
Posted by anilkumar gingade <ag...@pivotal.io>.
> On March 18, 2016, 9:21 p.m., Jason Huynh wrote:
> > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientInterestNotifyDUnitTest.java, line 109
> > <https://reviews.apache.org/r/45048/diff/1/?file=1306477#file1306477line109>
> >
> > Are destroys the final events that are supposed to arrive? just wondering if this criteria should include the other event types as well.
Yes...The last event is destroy...The sequence of operations are updates, invalidate and destroy...
- anilkumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45048/#review124287
-----------------------------------------------------------
On March 18, 2016, 9:16 p.m., anilkumar gingade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45048/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 9:16 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Test issue. Before validation test checks to see if the events are drained on the server side, but doesn't count for time taken to receive the event on client side and invoke its cache listener. Based on the machine speed and thread invocation timing, this test can intermediately fail.
>
> Added wait logic at client side CacheListener.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientInterestNotifyDUnitTest.java 1559506d068fe03f4f46de67abeab147ce08cf4a
>
> Diff: https://reviews.apache.org/r/45048/diff/
>
>
> Testing
> -------
>
> Run the test by simulating the problem (using sleep and changing the count) and validated test working as expected.
>
>
> Thanks,
>
> anilkumar gingade
>
>
Re: Review Request 45048: GEODE-559: CI Failure:
ClientInterestNotifyDUnitTest.testInterestNotify failed
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45048/#review124287
-----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientInterestNotifyDUnitTest.java (line 109)
<https://reviews.apache.org/r/45048/#comment186763>
Are destroys the final events that are supposed to arrive? just wondering if this criteria should include the other event types as well.
- Jason Huynh
On March 18, 2016, 9:16 p.m., anilkumar gingade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45048/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 9:16 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Test issue. Before validation test checks to see if the events are drained on the server side, but doesn't count for time taken to receive the event on client side and invoke its cache listener. Based on the machine speed and thread invocation timing, this test can intermediately fail.
>
> Added wait logic at client side CacheListener.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientInterestNotifyDUnitTest.java 1559506d068fe03f4f46de67abeab147ce08cf4a
>
> Diff: https://reviews.apache.org/r/45048/diff/
>
>
> Testing
> -------
>
> Run the test by simulating the problem (using sleep and changing the count) and validated test working as expected.
>
>
> Thanks,
>
> anilkumar gingade
>
>
Re: Review Request 45048: GEODE-559: CI Failure:
ClientInterestNotifyDUnitTest.testInterestNotify failed
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45048/
-----------------------------------------------------------
(Updated March 18, 2016, 9:16 p.m.)
Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, nabarun nag, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
Test issue. Before validation test checks to see if the events are drained on the server side, but doesn't count for time taken to receive the event on client side and invoke its cache listener. Based on the machine speed and thread invocation timing, this test can intermediately fail.
Added wait logic at client side CacheListener.
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientInterestNotifyDUnitTest.java 1559506d068fe03f4f46de67abeab147ce08cf4a
Diff: https://reviews.apache.org/r/45048/diff/
Testing (updated)
-------
Run the test by simulating the problem (using sleep and changing the count) and validated test working as expected.
Thanks,
anilkumar gingade