You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2009/05/08 03:06:45 UTC
[jira] Created: (HADOOP-5782) Make formatting of BlockManager.java
similar to FSNamesystem.java to simplify porting patch
Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch
-------------------------------------------------------------------------------------------
Key: HADOOP-5782
URL: https://issues.apache.org/jira/browse/HADOOP-5782
Project: Hadoop Core
Issue Type: Bug
Affects Versions: 0.21.0
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Priority: Minor
Fix For: 0.21.0
When block management code was refactored from FSNamesystem.java to BlockManager.java, some formatting changes are made. These changes make porting patches to BlockManager.java difficult.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5782) Make formatting of
BlockManager.java similar to FSNamesystem.java to simplify porting patch
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712365#action_12712365 ]
Hadoop QA commented on HADOOP-5782:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12408742/formatting.patch
against trunk revision 777761.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/384/console
This message is automatically generated.
> Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5782
> URL: https://issues.apache.org/jira/browse/HADOOP-5782
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.21.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: formatting.patch, formatting.patch
>
>
> When block management code was refactored from FSNamesystem.java to BlockManager.java, some formatting changes are made. These changes make porting patches to BlockManager.java difficult.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5782) Make formatting of BlockManager.java
similar to FSNamesystem.java to simplify porting patch
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5782:
------------------------------------
Status: Patch Available (was: Open)
> Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5782
> URL: https://issues.apache.org/jira/browse/HADOOP-5782
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.21.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: formatting.patch
>
>
> When block management code was refactored from FSNamesystem.java to BlockManager.java, some formatting changes are made. These changes make porting patches to BlockManager.java difficult.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5782) Make formatting of
BlockManager.java similar to FSNamesystem.java to simplify porting patch
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707201#action_12707201 ]
Raghu Angadi commented on HADOOP-5782:
--------------------------------------
+1. After applying this patch, the first patch attached to HADOOP-5780 applies cleanly just by changing the file name from FSNamesystem.java to BlockManager.java.
IMHO personally, the small block of code in metaSave() I looked at, looks better with this patch :-)
I think this can committed without going through highly backlogged Hudson.. could you run test-patch yourself?
> Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5782
> URL: https://issues.apache.org/jira/browse/HADOOP-5782
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.21.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: formatting.patch
>
>
> When block management code was refactored from FSNamesystem.java to BlockManager.java, some formatting changes are made. These changes make porting patches to BlockManager.java difficult.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5782) Make formatting of
BlockManager.java similar to FSNamesystem.java to simplify porting patch
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707207#action_12707207 ]
Suresh Srinivas commented on HADOOP-5782:
-----------------------------------------
Tests not included because the patch just formats the code. Here is the testpatch result:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
> Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5782
> URL: https://issues.apache.org/jira/browse/HADOOP-5782
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.21.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: formatting.patch
>
>
> When block management code was refactored from FSNamesystem.java to BlockManager.java, some formatting changes are made. These changes make porting patches to BlockManager.java difficult.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5782) Make formatting of BlockManager.java
similar to FSNamesystem.java to simplify porting patch
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5782:
------------------------------------
Attachment: formatting.patch
Retaining most of the format from FSNamesystem.java, except some of the cases where line exceeded 80 chars and unnecessary spaces.
> Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5782
> URL: https://issues.apache.org/jira/browse/HADOOP-5782
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.21.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: formatting.patch
>
>
> When block management code was refactored from FSNamesystem.java to BlockManager.java, some formatting changes are made. These changes make porting patches to BlockManager.java difficult.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5782) Make formatting of BlockManager.java
similar to FSNamesystem.java to simplify porting patch
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5782:
---------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
The above hudson error is expected since the patch is already committed. I forgot the resolve the issue last time.
> Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5782
> URL: https://issues.apache.org/jira/browse/HADOOP-5782
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.21.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: formatting.patch, formatting.patch
>
>
> When block management code was refactored from FSNamesystem.java to BlockManager.java, some formatting changes are made. These changes make porting patches to BlockManager.java difficult.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5782) Make formatting of BlockManager.java
similar to FSNamesystem.java to simplify porting patch
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5782:
------------------------------------
Attachment: formatting.patch
Reattaching the patch for the changed trunk. No unit tests added as this is formatting change. Here is the test-patch result:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
> Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5782
> URL: https://issues.apache.org/jira/browse/HADOOP-5782
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.21.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: formatting.patch, formatting.patch
>
>
> When block management code was refactored from FSNamesystem.java to BlockManager.java, some formatting changes are made. These changes make porting patches to BlockManager.java difficult.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5782) Make formatting of
BlockManager.java similar to FSNamesystem.java to simplify porting patch
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711833#action_12711833 ]
Raghu Angadi commented on HADOOP-5782:
--------------------------------------
I just committed this. Thanks Suresh!
> Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5782
> URL: https://issues.apache.org/jira/browse/HADOOP-5782
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.21.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: formatting.patch, formatting.patch
>
>
> When block management code was refactored from FSNamesystem.java to BlockManager.java, some formatting changes are made. These changes make porting patches to BlockManager.java difficult.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.