You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/11 10:45:32 UTC

[GitHub] [activemq-nms-openwire] brudo commented on pull request #3: Fix for NMS failover/TLS bug, AMQNET-572, by saving an Ssl context

brudo commented on pull request #3:
URL: https://github.com/apache/activemq-nms-openwire/pull/3#issuecomment-777355618


   @michaelpearce-gain, that was mainly responding to comments from @Havret and @dtaflin. Perhaps also adding my own review; perhaps trying to size up the remaining problems.
   
   I haven't done any more actual work on this. I did prepare a branch in my fork with the same changes, rebased. The actual source code is identical, and would be subject to the same comments expressed here.
   
   Meanwhile, in the branch for this PR, should I revert the merge commit that led to the bad diff in FailoverTransport.cs?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org