You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/01 07:30:57 UTC
[GitHub] [arrow] kou opened a new pull request, #35380: GH-35379: [C++][FlightRPC] Add teardown needed checks to avoid crash on error
kou opened a new pull request, #35380:
URL: https://github.com/apache/arrow/pull/35380
### Rationale for this change
If `ARROW_TEST_DATA` isn't set, `arrow-flight-test` is crashed:
```console
$ LD_LIBRARY_PATH=$PWD/debug debug/arrow-flight-test
...
[----------] 4 tests from TestTls
[ RUN ] TestTls.DoAction
E0501 16:24:25.455014704 800882 ssl_security_connector.cc:270] Handshaker factory creation failed with TSI_INVALID_ARGUMENT.
E0501 16:24:25.455054228 800882 chttp2_server.cc:1045] UNKNOWN:Unable to create secure server with credentials of type Ssl {file:"./src/core/ext/transport/chttp2/server/chttp2_server.cc", file_line:1032, created_time:"2023-05-01T16:24:25.455046974+09:00"}
/home/kou/work/cpp/arrow.kou/cpp/src/arrow/flight/flight_test.cc:396: Failure
Failed
'ExampleTlsCertificates(&options.tls_certificates)' failed with IOError: Test resources not found, set ARROW_TEST_DATA to <repo root>/testing/data
../cpp/src/arrow/flight/test_util.cc:784 GetTestResourceRoot(&root)
```
Because `client_` isn't created and `server_->Init()` isn't called when this error is occurred and `TearDown()` is executed.
### What changes are included in this PR?
Executes each teardown process only when they are needed.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35380: GH-35379: [C++][FlightRPC] Add teardown needed checks to avoid crash on error
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35380:
URL: https://github.com/apache/arrow/pull/35380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35380: GH-35379: [C++][FlightRPC] Add teardown needed checks to avoid crash on error
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35380:
URL: https://github.com/apache/arrow/pull/35380#issuecomment-1529439786
:warning: GitHub issue #35379 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35380: GH-35379: [C++][FlightRPC] Add teardown needed checks to avoid crash on error
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35380:
URL: https://github.com/apache/arrow/pull/35380#issuecomment-1529439736
* Closes: #35379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35380: GH-35379: [C++][FlightRPC] Add teardown needed checks to avoid crash on error
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35380:
URL: https://github.com/apache/arrow/pull/35380#issuecomment-1529843266
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/e66b452251a8470b92983125895a52d8...2e705648fbb24b049e771a818795d9d8/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35380: GH-35379: [C++][FlightRPC] Add teardown needed checks to avoid crash on error
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35380:
URL: https://github.com/apache/arrow/pull/35380#issuecomment-1529841515
Benchmark runs are scheduled for baseline = 75439f09a5eb6fbe21622dfb31c2be37a8cc0afd and contender = 41adf00652bf6788581f9adc4c007af5c1de3d56. 41adf00652bf6788581f9adc4c007af5c1de3d56 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:25.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d1e45c922f914bafae7811424e198ae0...b2c9ffcaed13464ea088e00c70ad23a9/)
[Failed :arrow_down:2.83% :arrow_up:0.38%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e66b452251a8470b92983125895a52d8...2e705648fbb24b049e771a818795d9d8/)
[Failed :arrow_down:0.52% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/56989b858e8a4b6c9a46b4620f330743...f1433e6901184586b77b4b189ffa4137/)
[Finished :arrow_down:0.45% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0b74736e6b7146a2a5676c29c3f71889...4190c6fe3df44336889856760f8569a7/)
Buildkite builds:
[Finished] [`41adf006` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2800)
[Failed] [`41adf006` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2834)
[Failed] [`41adf006` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2798)
[Finished] [`41adf006` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2825)
[Finished] [`75439f09` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2799)
[Failed] [`75439f09` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2833)
[Failed] [`75439f09` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2797)
[Finished] [`75439f09` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2824)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org