You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2015/06/19 10:43:03 UTC

[GitHub] flink pull request: [FLINK-2242] deprecate RemoteCollector interfa...

GitHub user mxm opened a pull request:

    https://github.com/apache/flink/pull/852

    [FLINK-2242] deprecate RemoteCollector interface and implementation

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/flink FLINK-2242

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/852.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #852
    
----
commit a2afab6faaa0bb81fe4780739cb40a7683eea46d
Author: Maximilian Michels <mx...@apache.org>
Date:   2015-06-19T08:39:27Z

    [FLINK-2242] deprecate RemoteCollector interface and implementation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2242] deprecate RemoteCollector interfa...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/852#issuecomment-119228088
  
    Looks good, merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2242] deprecate RemoteCollector interfa...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/852#issuecomment-114043900
  
    +1
    
    I would go as far as to remove it, as this will work in a very limited way and requires direct client to TaskManager communication.
    
    `DataSet.collect()` should fully subsume this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2242] deprecate RemoteCollector interfa...

Posted by mxm <gi...@git.apache.org>.

Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/852#issuecomment-114058851
  
    I would prefer deprecating it first and removing it in the next major release. If we would do so we should create a JIRA issue to keep track of removing it for the future release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2242] deprecate RemoteCollector interfa...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/852


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2242] deprecate RemoteCollector interfa...

Posted by uce <gi...@git.apache.org>.

Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/852#issuecomment-114044528
  
    I've opened the issue to deprecate, but I think removing is good. +1 to remove as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---