You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Thomas Neidhart (Created) (JIRA)" <ji...@apache.org> on 2012/04/02 22:05:23 UTC
[jira] [Created] (CODEC-138) Complete FilterInputStream interface
for BaseNCodecInputStream
Complete FilterInputStream interface for BaseNCodecInputStream
--------------------------------------------------------------
Key: CODEC-138
URL: https://issues.apache.org/jira/browse/CODEC-138
Project: Commons Codec
Issue Type: Improvement
Reporter: Thomas Neidhart
Attachments: CODEC-138.patch
Small patch to implement mark and reset in a safe manner.
markSupported is already implemented, but the other two methods are inherited from the default FilterInputStream implementation, which calls the corresponding methods of the underlying stream. The patch provides a noop implementation for mark, and throws an IOException when reset is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-138) Complete FilterInputStream interface
for BaseNCodecInputStream
Posted by "Thomas Neidhart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245527#comment-13245527 ]
Thomas Neidhart commented on CODEC-138:
---------------------------------------
I think IOException is more consistent with the standard jdk, as it is thrown when reset is not supported or mark has not been called before.
> Complete FilterInputStream interface for BaseNCodecInputStream
> --------------------------------------------------------------
>
> Key: CODEC-138
> URL: https://issues.apache.org/jira/browse/CODEC-138
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Thomas Neidhart
> Fix For: 1.7
>
> Attachments: CODEC-138.patch
>
>
> Small patch to implement mark and reset in a safe manner.
> markSupported is already implemented, but the other two methods are inherited from the default FilterInputStream implementation, which calls the corresponding methods of the underlying stream. The patch provides a noop implementation for mark, and throws an IOException when reset is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-138) Complete FilterInputStream interface
for BaseNCodecInputStream
Posted by "Gary D. Gregory (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245518#comment-13245518 ]
Gary D. Gregory commented on CODEC-138:
---------------------------------------
Wouldn't UnsupportedOperationException be better?
> Complete FilterInputStream interface for BaseNCodecInputStream
> --------------------------------------------------------------
>
> Key: CODEC-138
> URL: https://issues.apache.org/jira/browse/CODEC-138
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Thomas Neidhart
> Fix For: 1.7
>
> Attachments: CODEC-138.patch
>
>
> Small patch to implement mark and reset in a safe manner.
> markSupported is already implemented, but the other two methods are inherited from the default FilterInputStream implementation, which calls the corresponding methods of the underlying stream. The patch provides a noop implementation for mark, and throws an IOException when reset is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-138) Complete FilterInputStream interface
for BaseNCodecInputStream
Posted by "Sebb (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245570#comment-13245570 ]
Sebb commented on CODEC-138:
----------------------------
Note: InputStream.reset() throws IOE so I think the patch is correct.
> Complete FilterInputStream interface for BaseNCodecInputStream
> --------------------------------------------------------------
>
> Key: CODEC-138
> URL: https://issues.apache.org/jira/browse/CODEC-138
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Thomas Neidhart
> Fix For: 1.7
>
> Attachments: CODEC-138.patch
>
>
> Small patch to implement mark and reset in a safe manner.
> markSupported is already implemented, but the other two methods are inherited from the default FilterInputStream implementation, which calls the corresponding methods of the underlying stream. The patch provides a noop implementation for mark, and throws an IOException when reset is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-138) Complete FilterInputStream interface
for BaseNCodecInputStream
Posted by "Thomas Neidhart (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Neidhart updated CODEC-138:
----------------------------------
Attachment: CODEC-138.patch
> Complete FilterInputStream interface for BaseNCodecInputStream
> --------------------------------------------------------------
>
> Key: CODEC-138
> URL: https://issues.apache.org/jira/browse/CODEC-138
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Thomas Neidhart
> Attachments: CODEC-138.patch
>
>
> Small patch to implement mark and reset in a safe manner.
> markSupported is already implemented, but the other two methods are inherited from the default FilterInputStream implementation, which calls the corresponding methods of the underlying stream. The patch provides a noop implementation for mark, and throws an IOException when reset is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (CODEC-138) Complete FilterInputStream interface
for BaseNCodecInputStream
Posted by "Gary D. Gregory (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary D. Gregory closed CODEC-138.
---------------------------------
In SVN.
> Complete FilterInputStream interface for BaseNCodecInputStream
> --------------------------------------------------------------
>
> Key: CODEC-138
> URL: https://issues.apache.org/jira/browse/CODEC-138
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Thomas Neidhart
> Fix For: 1.7
>
> Attachments: CODEC-138.patch
>
>
> Small patch to implement mark and reset in a safe manner.
> markSupported is already implemented, but the other two methods are inherited from the default FilterInputStream implementation, which calls the corresponding methods of the underlying stream. The patch provides a noop implementation for mark, and throws an IOException when reset is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-138) Complete FilterInputStream interface
for BaseNCodecInputStream
Posted by "Sebb (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved CODEC-138.
------------------------
Resolution: Fixed
Fix Version/s: 1.7
> Complete FilterInputStream interface for BaseNCodecInputStream
> --------------------------------------------------------------
>
> Key: CODEC-138
> URL: https://issues.apache.org/jira/browse/CODEC-138
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Thomas Neidhart
> Fix For: 1.7
>
> Attachments: CODEC-138.patch
>
>
> Small patch to implement mark and reset in a safe manner.
> markSupported is already implemented, but the other two methods are inherited from the default FilterInputStream implementation, which calls the corresponding methods of the underlying stream. The patch provides a noop implementation for mark, and throws an IOException when reset is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira