You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/17 02:08:48 UTC

[GitHub] [calcite-avatica-go] F21 edited a comment on pull request #50: Replace ExecuteRequest with ExecuteBatchRequest

F21 edited a comment on pull request #50:
URL: https://github.com/apache/calcite-avatica-go/pull/50#issuecomment-645044733


   Thank you! That looks great!
   
   Just 2 more small things:
   - In the [documentation](https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_client_reference.md#dsn-data-source-name), you should add that the statement will only be executed when `Close()` is called.
   - There's a small typo in your latest commit message. It should be `[CALCITE-4067] Add support for ExecuteBatchRequest in prepared statement (chenhualin)`
   
   Other than that, squash your commits and I'll merge this :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org