You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2023/01/16 14:59:42 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #1227: Add ParseFloat and replace stod with it
PragmaTwice opened a new pull request, #1227:
URL: https://github.com/apache/incubator-kvrocks/pull/1227
We add `ParseFloat` to `parse_util.h` and replace most of `std::stod` with this newly added function in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1227: Add ParseFloat and replace stod with it
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #1227:
URL: https://github.com/apache/incubator-kvrocks/pull/1227#issuecomment-1384227126
I notice that gcc implemented floating-point version `std::from_chars` since 11.1, which is a sad story. It means we cannot use `std::from_chars` because it comes too late and the gcc version is too new for some users. So I will implement it using `strto*` in c std library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1227: Add ParseFloat and replace stod with it
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #1227:
URL: https://github.com/apache/incubator-kvrocks/pull/1227#issuecomment-1384922345
Thanks all. Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1227: Add ParseFloat and replace stod with it
Posted by GitBox <gi...@apache.org>.
PragmaTwice merged PR #1227:
URL: https://github.com/apache/incubator-kvrocks/pull/1227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1227: Add ParseFloat and replace stod with it
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #1227:
URL: https://github.com/apache/incubator-kvrocks/pull/1227#issuecomment-1384750112
> I notice that gcc implemented floating-point version `std::from_chars` since 11.1, which is a sad story. It means we cannot use `std::from_chars` because it comes too late and the gcc version is too new for some users. So I will implement it using `strto*` in c std library instead.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org