[GitHub] [netbeans] Chris2011 commented on a change in pull request #1034: NETBEANS-1499 - change package.json icon

[GitBox <gi...@apache.org>]

Chris2011 commented on a change in pull request #1034: NETBEANS-1499 - change package.json icon
URL: https://github.com/apache/netbeans/pull/1034#discussion_r281948551
 
 

 ##########
 File path: webcommon/javascript.nodejs/src/org/netbeans/modules/javascript/nodejs/resources/npm-resolver.xml
 ##########
 @@ -26,4 +26,12 @@
         <name name="package.json"/>
         <resolver mime="text/package+x-json"/>
     </file>
+    <file>
+        <name name="package-lock.json"/>
+        <resolver mime="text/package-lock+x-json"/>
+    </file>
+    <file>
+        <name name="npm-debug.log"/>
+        <resolver mime="text/plain"/>
 
 Review comment:
   Oops, I didn't know that. I thought the combination of resolver AND filename in this example is enough to make it unique. So for this I really need a new mimetype, right? text/package+plain or text/npm-debug-log. Looks weirdo. Any other solutions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists