You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "HaiyuanZhao (Jira)" <ji...@apache.org> on 2021/06/25 17:22:00 UTC
[jira] [Comment Edited] (KAFKA-10884) Limit the size of Fetch and
FetchSnapshot response based on broker configuration
[ https://issues.apache.org/jira/browse/KAFKA-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369437#comment-17369437 ]
HaiyuanZhao edited comment on KAFKA-10884 at 6/25/21, 5:21 PM:
---------------------------------------------------------------
Hi, [~jagsancio]
I would like to take this if this issue is still open.
===================================
Update: Hey, I am not sure if these limitations still need to be added based on the following two observations.
*FetchRequest*
When I was trying to add the size limitation for fetch/fetchSnapshot request, I noticed size limitation for fetch request had been added. which is 8 * 1024 * 1024(MAX_BATCH_SIZE_BYTES). This limitation comes from commit 0685b9dcd5e47ea1d543c475e3af6f833b4bb633
*FetchSnapshotRequest*
I also noticed this size is not limited for fetchSnapshot request. And maxBytes is set to
Integer.MAX_VALUE in KafkaRaftClientSnapshotTest
Could you give me some advices?
was (Author: zhaohaidao):
Hi, [~jagsancio]
I would like to take this if this issue is still open
> Limit the size of Fetch and FetchSnapshot response based on broker configuration
> --------------------------------------------------------------------------------
>
> Key: KAFKA-10884
> URL: https://issues.apache.org/jira/browse/KAFKA-10884
> Project: Kafka
> Issue Type: Sub-task
> Components: replication
> Reporter: Jose Armando Garcia Sancio
> Assignee: HaiyuanZhao
> Priority: Major
>
> The Raft Client implementation for Fetch and FetchSnapshot do not limit the size of the response sent based on the local configuration of replica.fetch.response.max.bytes. Fix this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)