You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sarangan12 <gi...@git.apache.org> on 2016/02/17 23:59:39 UTC
[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-windows/pull/151
CB-10640: Windows logging is broken
CB-10640: Windows logging is broken
@dblotsky @riknoll @rakatyal @nikhilkh Can you please review and merge this PR?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarangan12/cordova-windows CB-10640
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/151.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #151
----
commit b4392c676c485ba96222b1edb3b4c5853c8eebf3
Author: Sarangan Rajamanickam <sa...@microsoft.com>
Date: 2016-02-17T22:58:30Z
CB-10640: Windows logging is broken
CB-10640: Windows logging is broken
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 closed the pull request at:
https://github.com/apache/cordova-windows/pull/151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/151#discussion_r53257649
--- Diff: template/cordova/lib/log.js ---
@@ -151,23 +154,23 @@ function exitGracefully(exitCode) {
}
function startLogging(channel) {
- var startTime = new Date().toISOString();
+ var logFromTime = 10 * ONE_MINUTE;
--- End diff --
This is set to the default value twice, [here][case1] and [there][case2], how come?
[case1]: https://github.com/apache/cordova-windows/pull/151/files#diff-378bd5207000848de6b771d61b037e2fR157
[case2]: https://github.com/apache/cordova-windows/pull/151/files#diff-378bd5207000848de6b771d61b037e2fR53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/151#discussion_r53250824
--- Diff: template/cordova/lib/log.js ---
@@ -47,10 +47,10 @@ var appTracingInitialState = null,
* and prints them to console
*/
module.exports.run = function(args) {
- var startTime = new Date(new Date().getTime() - 10 * 60 * 1000).toISOString(), // show last 10 minutes by default
- knownOpts = { 'minutes' : Number, 'dump' : Boolean, 'help' : Boolean },
- shortHands = { 'mins' : ['--minutes'], 'h' : ['--help'] },
- parsedOpts = nopt(knownOpts, shortHands, args, 0);
+ var logFromTime = 10 * 60 * 1000; // show last 10 minutes by default
--- End diff --
@dblotsky Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/151#discussion_r53247772
--- Diff: template/cordova/lib/log.js ---
@@ -47,10 +47,10 @@ var appTracingInitialState = null,
* and prints them to console
*/
module.exports.run = function(args) {
- var startTime = new Date(new Date().getTime() - 10 * 60 * 1000).toISOString(), // show last 10 minutes by default
- knownOpts = { 'minutes' : Number, 'dump' : Boolean, 'help' : Boolean },
- shortHands = { 'mins' : ['--minutes'], 'h' : ['--help'] },
- parsedOpts = nopt(knownOpts, shortHands, args, 0);
+ var startTime = 10 * 60 * 1000; // show last 10 minutes by default
--- End diff --
@riknoll Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/151#discussion_r53247225
--- Diff: template/cordova/lib/log.js ---
@@ -47,10 +47,10 @@ var appTracingInitialState = null,
* and prints them to console
*/
module.exports.run = function(args) {
- var startTime = new Date(new Date().getTime() - 10 * 60 * 1000).toISOString(), // show last 10 minutes by default
- knownOpts = { 'minutes' : Number, 'dump' : Boolean, 'help' : Boolean },
- shortHands = { 'mins' : ['--minutes'], 'h' : ['--help'] },
- parsedOpts = nopt(knownOpts, shortHands, args, 0);
+ var startTime = 10 * 60 * 1000; // show last 10 minutes by default
--- End diff --
Nitpick: It would be nice to rename startTime to something else. It isn't really a start time anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/151#discussion_r53248411
--- Diff: template/cordova/lib/log.js ---
@@ -47,10 +47,10 @@ var appTracingInitialState = null,
* and prints them to console
*/
module.exports.run = function(args) {
- var startTime = new Date(new Date().getTime() - 10 * 60 * 1000).toISOString(), // show last 10 minutes by default
- knownOpts = { 'minutes' : Number, 'dump' : Boolean, 'help' : Boolean },
- shortHands = { 'mins' : ['--minutes'], 'h' : ['--help'] },
- parsedOpts = nopt(knownOpts, shortHands, args, 0);
+ var logFromTime = 10 * 60 * 1000; // show last 10 minutes by default
--- End diff --
Might be useful to define `ONE_MINUTE` and then just say `10 * ONE_MINUTE` or `parsedOpts.minutes * ONE_MINUTE`, in order to avoid duplication of `60 * 1000`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/151#issuecomment-185453467
+ @alsorokin to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org