You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/19 04:58:45 UTC

[GitHub] [cloudstack-primate] nvazquez opened a new pull request #593: Improve vApps properties section adding categories and sort order

nvazquez opened a new pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593


   For deploy-as-is templates:
   - Add category when available
   - Sort properties in the order defined in the template


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676211248


   @nvazquez can you test, I can merge if it works now
   @blueorangutan package 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676209477


   ![Screenshot from 2020-08-19 17-13-51](https://user-images.githubusercontent.com/153340/90630854-68f62400-e23f-11ea-966a-a93046081b54.png)
   Added a-alert component and fixed above error


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676254184


   Not good - there should be 3 categories, instead of 1:
   
   ![image](https://user-images.githubusercontent.com/45762285/90633594-9a162a80-e226-11ea-8a17-e9754b9244c9.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675903649


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/593 (JID-3255)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676285842


   LGTM - both the vApp categories and the questions in each  -  are sorted properly - as in the OVF
   thx!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676230511


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/593 (JID-3260)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676158848


   @shwstppr would it be quicker for you to address issues or advise Nicolas? Thanks.
   @nvazquez @shwstppr cc @davidjumani - pl advise me accordingly happy to merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676259871


   Merging this as Abhishek confirms testing this. cc @andrijapanicsb please log further issues, I'm merging this so you can then take latest Primate and carry on vApp backend testing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675898993


   cc @shwstppr
   LGTM
   @blueorangutan package 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#discussion_r472897201



##########
File path: src/views/compute/DeployVM.vue
##########
@@ -1791,4 +1806,10 @@ export default {
   .form-item-hidden {
     display: none;
   }
+
+  .vapp-category {
+    background-color: lightblue;

Review comment:
       ![Screenshot from 2020-08-19 15-04-24](https://user-images.githubusercontent.com/153340/90618225-4f4be100-e22d-11ea-82af-8af90da750ab.png)
   Can we use some standard primate color. Looks different to rest of the UI




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676213006


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675912527


   Regression test LGTM, tried to deploy a VM with some changes in templates and root disk size override


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675899267


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] andrijapanicsb removed a comment on pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
andrijapanicsb removed a comment on pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676254184


   Not good - there should be 3 categories, instead of 1:
   
   ![image](https://user-images.githubusercontent.com/45762285/90633594-9a162a80-e226-11ea-8a17-e9754b9244c9.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #593: Improve vApps properties section adding categories and sort order

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#discussion_r472931498



##########
File path: src/views/compute/DeployVM.vue
##########
@@ -1791,4 +1806,10 @@ export default {
   .form-item-hidden {
     display: none;
   }
+
+  .vapp-category {
+    background-color: lightblue;

Review comment:
       use the alert component




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org