You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/10/20 03:04:30 UTC

[GitHub] [submarine] brayce1996 opened a new pull request #438: [SUBMARINE-611] Fix a bug in add new project page

brayce1996 opened a new pull request #438:
URL: https://github.com/apache/submarine/pull/438


   ### What is this PR for?
   "Create new project page" UI makes the "Next Step button" become clickable before all required fields are filled.
   Now the button would stay unclickable until users filled all required fields.
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-611
   
   ### How should this be tested?
   https://travis-ci.org/github/brayce1996/submarine/builds/736928222
   
   ### Screenshots (if appropriate)
   1. Visibility is not filled, so Next Step button is disabled.
   ![image](https://user-images.githubusercontent.com/18074733/96534746-ef23fa80-12c2-11eb-916a-61617604a0b5.png)
   2. Visibility is filled, but public visibility requires Permission to be filled. Next Step button is disabled.
   ![image](https://user-images.githubusercontent.com/18074733/96534788-02cf6100-12c3-11eb-9f8e-d9a90d02624f.png)
   3. All required fields are filled, so Next Step button is enabled.
   ![image](https://user-images.githubusercontent.com/18074733/96534981-72455080-12c3-11eb-8e24-8892eef02269.png)
   
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org