You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/12 15:06:01 UTC

[GitHub] [flink] NicoK commented on a change in pull request #10113: [FLINK-13749][client] Make PackagedProgram respect classloading policy

NicoK commented on a change in pull request #10113: [FLINK-13749][client] Make PackagedProgram respect classloading policy
URL: https://github.com/apache/flink/pull/10113#discussion_r345256835
 
 

 ##########
 File path: flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java
 ##########
 @@ -91,15 +93,21 @@ public static void checkJarFile(URL jar) throws IOException {
 		}
 	}
 
-	public static ClassLoader buildUserCodeClassLoader(List<URL> jars, List<URL> classpaths, ClassLoader parent) {
+	public static ClassLoader buildUserCodeClassLoader(List<URL> jars, List<URL> classpaths, ClassLoader parent,
+														Configuration configuration) {
 
 Review comment:
   please use one parameter per line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services