You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2026/03/25 22:56:53 UTC
[PR] Java: Additional flag to name conversion for SYNCHRONIZED_OR_ACC_SUPER and VOLATILE_OR_ACC_BRIDGE [netbeans]
matthiasblaesing opened a new pull request, #9296:
URL: https://github.com/apache/netbeans/pull/9296
Closes: #9294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Java: Additional flag to name conversion for SYNCHRONIZED_OR_ACC_SUPER and VOLATILE_OR_ACC_BRIDGE [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #9296:
URL: https://github.com/apache/netbeans/pull/9296#issuecomment-4135753411
@mbien I see. I updated this PR to use `toString`. The differences can be seen here. The list holds all entries where `toString` and the `toLowerCase` versions are not idenitical:
| Enum Value | toString() | toLowerCase() |
| ---------- | ---------- | ------------- |
| SYNCHRONIZED_OR_ACC_SUPER | synchronized | synchronized_or_acc_super |
| VOLATILE_OR_ACC_BRIDGE | volatile | volatile_or_acc_bridge |
| TRANSIENT_OR_ACC_VARARGS | transient | transient_or_acc_varargs |
| MANDATED_OR_ACC_MODULE | mandated | mandated_or_acc_module |
| DEPRECATED_OR_BODY_ONLY_FINALIZE | deprecated or body_only_finalize | deprecated_or_body_only_finalize |
| COMPOUND_OR_GENERATED_MEMBER | compound or generated_member | compound_or_generated_member |
| ANONCONSTR_OR_SUPER_OWNER_ATTRIBUTED | anonconstr or super_owner_attributed | anonconstr_or_super_owner_attributed |
| NOT_IN_PROFILE_OR_BAD_OVERRIDE | not_in_profile or bad_override | not_in_profile_or_bad_override |
| LAMBDA_METHOD_OR_LOCAL_CAPTURE_FIELD | lambda_method or local_capture_field | lambda_method_or_local_capture_field |
| MODULE_OR_COMPACT_RECORD_CONSTRUCTOR_OR_UNINITIALIZED_FIELD | module or compact_record_constructor or uninitialized_field | module_or_compact_record_constructor_or_uninitialized_field |
| AUTOMATIC_MODULE_OR_HAS_RESOURCE_OR_NAME_FILLED | automatic_module or has_resource or name_filled | automatic_module_or_has_resource_or_name_filled |
| SYSTEM_MODULE_OR_VALUE_BASED_OR_FIELD_INIT_TYPE_ANNOTATIONS_QUEUED | system_module or value_based or field_init_type_annotations_queued | system_module_or_value_based_or_field_init_type_annotations_queued |
| RESTRICTED_OR_REQUIRES_IDENTITY | restricted or requires_identity | restricted_or_requires_identity |
| NON_SEALED | non-sealed | non_sealed |
The existing cases `TRANSIENT_OR_ACC_VARARGS` and `NON_SEALED` are correctly covered and the new cases are also correctly transated. The changes for the other values look sensible to me and should not affect us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Java: Additional flag to name conversion for SYNCHRONIZED_OR_ACC_SUPER and VOLATILE_OR_ACC_BRIDGE [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #9296:
URL: https://github.com/apache/netbeans/pull/9296#issuecomment-4132886093
@mbien could you please have a look? The shared constants in javac might mean that the print routine needs more context in the future, but for now this should at least fix the problem for the current nbjavac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Java: Additional flag to name conversion for SYNCHRONIZED_OR_ACC_SUPER and VOLATILE_OR_ACC_BRIDGE [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #9296:
URL: https://github.com/apache/netbeans/pull/9296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists