You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/06/07 16:57:28 UTC

[GitHub] [phoenix] dbwong commented on a change in pull request #515: PHOENIX-5318 Slots passed to SkipScan filter is incorrect for desc pr…

dbwong commented on a change in pull request #515: PHOENIX-5318 Slots passed to SkipScan filter is incorrect for desc pr…
URL: https://github.com/apache/phoenix/pull/515#discussion_r291644215
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/query/KeyRange.java
 ##########
 @@ -108,6 +109,34 @@ public KeyRange apply(byte[] input) {
         }
     };
 
 
 Review comment:
   Is there anything wrong with using Comparator.reverseOrder why have some of this code duplicated?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services