You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/23 11:06:59 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5005: Make
calcite parser support order by expression
codecov-io edited a comment on issue #5005: Make calcite parser support order by expression
URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577528692
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr&el=h1) Report
> Merging [#5005](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c3117d0ed32438a75bebf5f53be0b259f5a64aac?src=pr&el=desc) will **decrease** coverage by `5.5%`.
> The diff coverage is `36.58%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5005 +/- ##
============================================
- Coverage 57.29% 51.78% -5.51%
Complexity 12 12
============================================
Files 1179 1179
Lines 62731 62762 +31
Branches 9204 9213 +9
============================================
- Hits 35944 32504 -3440
- Misses 24106 27770 +3664
+ Partials 2681 2488 -193
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `87.79% <100%> (+0.11%)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `87.68% <100%> (+4.1%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/pql/parsers/pql2/ast/SelectAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9TZWxlY3RBc3ROb2RlLmphdmE=) | `97.89% <100%> (+0.04%)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/parsers/utils/BrokerRequestComparisonUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wYXJzZXJzL3V0aWxzL0Jyb2tlclJlcXVlc3RDb21wYXJpc29uVXRpbHMuamF2YQ==) | `23.92% <13.33%> (-8.17%)` | `0 <0> (ø)` | |
| [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | |
| [...converter/stats/RealtimeSegmentStatsContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVTZWdtZW50U3RhdHNDb250YWluZXIuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | |
| [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `0% <0%> (-93.19%)` | `0% <0%> (ø)` | |
| [.../starter/helix/HelixInstanceDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-92.31%)` | `0% <0%> (ø)` | |
| [...ot/tools/query/comparison/SegmentInfoProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU2VnbWVudEluZm9Qcm92aWRlci5qYXZh) | `0% <0%> (-88.68%)` | `0% <0%> (ø)` | |
| [.../transform/function/MapValueTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTWFwVmFsdWVUcmFuc2Zvcm1GdW5jdGlvbi5qYXZh) | `0% <0%> (-85.3%)` | `0% <0%> (ø)` | |
| ... and [202 more](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr&el=footer). Last update [c3117d0...38ee798](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org