You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/03/14 10:39:18 UTC

[GitHub] [spark] hvanhovell commented on a diff in pull request #40413: [WIP]Typed Select

hvanhovell commented on code in PR #40413:
URL: https://github.com/apache/spark/pull/40413#discussion_r1135341292


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/AgnosticEncoder.scala:
##########
@@ -107,6 +108,51 @@ object AgnosticEncoders {
     override def dataType: DataType = schema
   }
 
+  case class TupleEncoder[T](

Review Comment:
   @zhenlineo we should be able to use `ProductEncoder` for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org