[GitHub] [incubator-sdap-nexus] tloubrieu-jpl commented on a change in pull request #106: SDAP-278 Cassandra username/password suport

[GitBox <gi...@apache.org>]

tloubrieu-jpl commented on a change in pull request #106:
URL: https://github.com/apache/incubator-sdap-nexus/pull/106#discussion_r467321628



##########
File path: analysis/webservice/algorithms/HofMoeller.py
##########
@@ -168,7 +168,7 @@ def calc(self, computeOptions, **args):
                 result = done_queue.get()
                 try:
                     error_str = result['error']
-                    self.log.error(error_str)

Review comment:
       I asked myself before what is the best way to handle loggers in object. I used to have logger as global variable in the file but I has notice that log was often an attribute of the object. Do you have an opinion on that ?

##########
File path: analysis/webservice/algorithms_spark/DailyDifferenceAverageSpark.py
##########
@@ -264,7 +267,7 @@ def determine_parllelism(num_tiles):
     return num_partitions
 
 
-def spark_anomolies_driver(tile_ids, bounding_wkt, dataset, climatology, sc=None):
+def spark_anomalies_driver(tile_service_driver, tile_ids, bounding_wkt, dataset, climatology, sc=None):

Review comment:
       Should you name is tile_service_factory as in the other places in the code ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org