You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/06/25 19:19:43 UTC

[GitHub] [storm] srdo commented on a change in pull request #3035: STORM-3417: Fix checkstyle violations in sql-core

srdo commented on a change in pull request #3035: STORM-3417: Fix checkstyle violations in sql-core
URL: https://github.com/apache/storm/pull/3035#discussion_r297352148
 
 

 ##########
 File path: sql/storm-sql-core/src/jvm/org/apache/storm/sql/javac/CompilingClassLoader.java
 ##########
 @@ -125,7 +125,8 @@ public CompilingClassLoader(
     }
 
     /**
-     * @return Whether compilation was successful.
+     * Compiles source code to byte code.
 
 Review comment:
   Wasn't this check disabled?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services