You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/19 10:16:50 UTC
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7064: docs: update "Traffic" Plugin docs 3
juzhiyuan commented on code in PR #7064:
URL: https://github.com/apache/apisix/pull/7064#discussion_r876878380
##########
docs/en/latest/plugins/traffic-split.md:
##########
@@ -141,13 +152,27 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13
}'
```
->Note: **1.** Use the `upstream_id` to bind the defined upstream, it can reuse upstream health detection, retry and other functions. **2.** Support the two configuration methods of `upstream` and `upstream_id` to be used together.
+:::tip
+
+Configure via `upstream_id` to reuse Upstream's health detection, retires, and other functions.
+
+:::
+
+:::note
-## Example
+You can use both `upstream` configuration and `upstream_id` configuration together.
-### Grayscale Release
+:::
-The `match` rule part is missing, and the traffic is split according to the `weight` value configured by the `weighted_upstreams` in the plugin. Divide `plugin's upstream` and `route's upstream` according to the traffic ratio of 3:2, of which 60% of the traffic reaches the upstream of the `1981` port in the plugin, and 40% of the traffic reaches the default `1980` port on the route Upstream.
+## Example usage
+
+The examples below shows different use cases for using the `traffic-split` Plugin.
+
+### Grayscale/Canary release
Review Comment:
Please use Canary Release instead
##########
docs/en/latest/plugins/traffic-split.md:
##########
@@ -141,13 +152,27 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13
}'
```
->Note: **1.** Use the `upstream_id` to bind the defined upstream, it can reuse upstream health detection, retry and other functions. **2.** Support the two configuration methods of `upstream` and `upstream_id` to be used together.
+:::tip
+
+Configure via `upstream_id` to reuse Upstream's health detection, retires, and other functions.
+
+:::
+
+:::note
-## Example
+You can use both `upstream` configuration and `upstream_id` configuration together.
-### Grayscale Release
+:::
-The `match` rule part is missing, and the traffic is split according to the `weight` value configured by the `weighted_upstreams` in the plugin. Divide `plugin's upstream` and `route's upstream` according to the traffic ratio of 3:2, of which 60% of the traffic reaches the upstream of the `1981` port in the plugin, and 40% of the traffic reaches the default `1980` port on the route Upstream.
+## Example usage
+
+The examples below shows different use cases for using the `traffic-split` Plugin.
+
+### Grayscale/Canary release
Review Comment:
Others LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org