You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/10/28 07:50:25 UTC
[GitHub] [incubator-doris] xinghuayu007 opened a new pull request #4809: 【BUG】Catch runtime exception
xinghuayu007 opened a new pull request #4809:
URL: https://github.com/apache/incubator-doris/pull/4809
## Proposed changes
`select * from table where date in (20201030)` may cause partition pruning`RuntimeException`, it is not catched and compiling failed. See issue: #4805
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Yao-MR removed a comment on pull request #4809: 【BUG】Catch runtime exception
Posted by GitBox <gi...@apache.org>.
Yao-MR removed a comment on pull request #4809:
URL: https://github.com/apache/incubator-doris/pull/4809#issuecomment-717764578
in the level of exception of Runtime
i do not think is a good idea to catch and do not throw
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 commented on pull request #4809: 【BUG】Catch runtime exception
Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on pull request #4809:
URL: https://github.com/apache/incubator-doris/pull/4809#issuecomment-717773236
The RunTimeException is throwed by this function, not a real RunTimeException.
```
public static int compareLiteralExpr(LiteralExpr key1, LiteralExpr key2) {
int ret = 0;
if (key1 instanceof MaxLiteral || key2 instanceof MaxLiteral) {
ret = key1.compareLiteral(key2);
} else {
final Type destType = Type.getAssignmentCompatibleType(key1.getType(), key2.getType(), false);
try {
LiteralExpr newKey = key1;
if (key1.getType() != destType) {
newKey = (LiteralExpr) key1.castTo(destType);
}
LiteralExpr newOtherKey = key2;
if (key2.getType() != destType) {
newOtherKey = (LiteralExpr) key2.castTo(destType);
}
ret = newKey.compareLiteral(newOtherKey);
} catch (AnalysisException e) {
*************** throw new RuntimeException("Cast error in partition"); ******************
}
}
return ret;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Yao-MR commented on pull request #4809: 【BUG】Catch runtime exception
Posted by GitBox <gi...@apache.org>.
Yao-MR commented on pull request #4809:
URL: https://github.com/apache/incubator-doris/pull/4809#issuecomment-717764578
in the level of exception of Runtime
i do not think is a good idea to catch and do not throw
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 closed pull request #4809: 【BUG】Catch runtime exception
Posted by GitBox <gi...@apache.org>.
xinghuayu007 closed pull request #4809:
URL: https://github.com/apache/incubator-doris/pull/4809
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org