[jira] [Commented] (KAFKA-7560) PushHttpMetricsReporter should not convert metric value to double

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-7560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677207#comment-16677207 ] 

ASF GitHub Bot commented on KAFKA-7560:
---------------------------------------

lindong28 opened a new pull request #5886: KAFKA-7560; PushHttpMetricsReporter should not convert metric value t…
URL: https://github.com/apache/kafka/pull/5886
 
 
   @ijuma @omkreddy would you have time to review this patch? It seems to be the last issue for the 2.1 system test.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> PushHttpMetricsReporter should not convert metric value to double
> -----------------------------------------------------------------
>
>                 Key: KAFKA-7560
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7560
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 2.1.0
>            Reporter: Stanislav Kozlovski
>            Assignee: Dong Lin
>            Priority: Blocker
>
> Currently PushHttpMetricsReporter will convert value from KafkaMetric.metricValue() to double. This will not work for non-numerical metrics such as version in AppInfoParser whose value can be string. This has caused issue for PushHttpMetricsReporter which in turn caused system test kafkatest.tests.client.quota_test.QuotaTest.test_quota to fail with the following exception:  
> {code:java}
>  File "/opt/kafka-dev/tests/kafkatest/tests/client/quota_test.py", line 196, in validate     metric.value for k, metrics in producer.metrics(group='producer-metrics', name='outgoing-byte-rate', client_id=producer.client_id) for metric in metrics ValueError: max() arg is an empty sequence
> {code}
> Since we allow metric value to be object, PushHttpMetricsReporter should also read metric value as object and pass it to the http server.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)