You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Dmitri Plotnikov <dm...@apache.org> on 2002/06/16 16:19:44 UTC

[VOTE] Release vote for JXPath 1.0

I'd like to call for a release vote on JXPath 1.0 .  It has been stable for
a while, and there are no outstanding bugs against it.  All the goals we had
initially stated for this release have been met.

The release candidate build is

http://jakarta.apache.org/builds/jakarta-commons/release/commons-jxpath/v1.0

+1 (this is my vote)

Thank you,

Dmitri


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [VOTE] Release vote for JXPath 1.0

Posted by Juozas Baliuka <ba...@centras.lt>.
+1


> I'd like to call for a release vote on JXPath 1.0 .  It has been stable
for
> a while, and there are no outstanding bugs against it.  All the goals we
had
> initially stated for this release have been met.
>
> The release candidate build is
>
>
http://jakarta.apache.org/builds/jakarta-commons/release/commons-jxpath/v1.0
>
> +1 (this is my vote)
>
> Thank you,
>
> Dmitri
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [VOTE] Release vote for JXPath 1.0

Posted by Dmitri Plotnikov <dm...@apache.org>.
I have addressed these two requirements.  The ONLY changes are in the src.gz
and .zip: the directory name and the default target.

I will assume that this does not require a re-vote, I'll just wait for
another vote (crossing my fingers) and go ahead with the announcement.

Thanks,

- Dmitri

----- Original Message -----
From: "Jeff Turner" <je...@socialchange.net.au>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Sunday, June 16, 2002 10:00 PM
Subject: Re: [VOTE] Release vote for JXPath 1.0


> Only-glanced-at-the-code +1
>
> Two comments:
>
>  - I'd prefer the directory name to be 'commons-jxpath-<version>-src'
>    instead of just 'commons-jxpath'. Eg, when I checked it out, it
>    conflicted with files from the previous beta.
>  - How about changing the default target to 'jar', instead of 'compile'?
>
>
> --Jeff
>
> On Sun, Jun 16, 2002 at 10:19:44AM -0400, Dmitri Plotnikov wrote:
> > I'd like to call for a release vote on JXPath 1.0 .  It has been stable
for
> > a while, and there are no outstanding bugs against it.  All the goals we
had
> > initially stated for this release have been met.
> >
> > The release candidate build is
> >
> >
http://jakarta.apache.org/builds/jakarta-commons/release/commons-jxpath/v1.0
> >
> > +1 (this is my vote)
> >
> > Thank you,
> >
> > Dmitri
> >
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [VOTE] Release vote for JXPath 1.0

Posted by Jeff Turner <je...@socialchange.net.au>.
Only-glanced-at-the-code +1

Two comments:

 - I'd prefer the directory name to be 'commons-jxpath-<version>-src'
   instead of just 'commons-jxpath'. Eg, when I checked it out, it
   conflicted with files from the previous beta.
 - How about changing the default target to 'jar', instead of 'compile'?


--Jeff

On Sun, Jun 16, 2002 at 10:19:44AM -0400, Dmitri Plotnikov wrote:
> I'd like to call for a release vote on JXPath 1.0 .  It has been stable for
> a while, and there are no outstanding bugs against it.  All the goals we had
> initially stated for this release have been met.
> 
> The release candidate build is
> 
> http://jakarta.apache.org/builds/jakarta-commons/release/commons-jxpath/v1.0
> 
> +1 (this is my vote)
> 
> Thank you,
> 
> Dmitri
> 

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [VOTE] Release vote for JXPath 1.0

Posted by Ivelin Ivanov <iv...@apache.org>.
+1

(if it counts)



Dmitri Plotnikov wrote:
> I'd like to call for a release vote on JXPath 1.0 .  It has been stable for
> a while, and there are no outstanding bugs against it.  All the goals we had
> initially stated for this release have been met.
> 
> The release candidate build is
> 
> http://jakarta.apache.org/builds/jakarta-commons/release/commons-jxpath/v1.0
> 
> +1 (this is my vote)
> 
> Thank you,
> 
> Dmitri
> 
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
> 
> 



-- 

-= Ivelin =-


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [VOTE] Release vote for JXPath 1.0

Posted by Martin van den Bemt <ml...@mvdb.net>.

On Sun, 2002-06-16 at 17:06, Dmitri Plotnikov wrote:
> The problem is with the count.  The tests have internal structure - sorry,
> that might be bad idea, at least misleading.
> 
> The actual number of tests hiding behind the 8 you counted is about 350, you
> need to count each XPath that is being tested, because they are designed to
> provide very good coverage of the overall codebase.

I try to use a more direct approach testing classes and not indirect,
where possible. It helps debugging in the long term and catching
possible errors, which doesn't necessarily have to break the testcases.

As an example for your code base :

The QName.java equals method.
I would make a testcase for that object containing at least the
equalsmethod, so you know all the tests are failing, because your equals
is broken. 

> 
> I hope that addresses your concern.
> 

That's why I said that i am not -1'ing the release, since everyone has a
different approach on using tests, which isn't necessarily a bad thing..

Mvgr,
Martin

BTW the code is looking good ;)



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [VOTE] Release vote for JXPath 1.0

Posted by Dmitri Plotnikov <dm...@apache.org>.
The problem is with the count.  The tests have internal structure - sorry,
that might be bad idea, at least misleading.

The actual number of tests hiding behind the 8 you counted is about 350, you
need to count each XPath that is being tested, because they are designed to
provide very good coverage of the overall codebase.

I hope that addresses your concern.

- Dmitri

----- Original Message -----
From: "Martin van den Bemt" <ml...@mvdb.net>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Sunday, June 16, 2002 10:35 AM
Subject: Re: [VOTE] Release vote for JXPath 1.0


> I will not -1 it, but hear me out ;)
> I don't know jxpath (seen it around though), but just took a look at the
> sourcecode.
> It has about 8 testcases and that is a huge difference with the actual
> number of classes in the jxpath package.
> How can you asure that in the next release current behaviour is not
> breaking bacward compatibility, except for the fact that you can say "I
> seen it work" ? And of course the current release can have many bugs,
> which can only be revealed in testcases (not saying it is, don't get me
> wrong..)
>
> Mvgr,
> Martin
>
> On Sun, 2002-06-16 at 16:19, Dmitri Plotnikov wrote:
> > I'd like to call for a release vote on JXPath 1.0 .  It has been stable
for
> > a while, and there are no outstanding bugs against it.  All the goals we
had
> > initially stated for this release have been met.
> >
> > The release candidate build is
> >
> >
http://jakarta.apache.org/builds/jakarta-commons/release/commons-jxpath/v1.0
> >
> > +1 (this is my vote)
> >
> > Thank you,
> >
> > Dmitri
> >
> >
> > --
> > To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> > For additional commands, e-mail:
<ma...@jakarta.apache.org>
> >
> >
>
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [VOTE] Release vote for JXPath 1.0

Posted by Juozas Baliuka <ba...@centras.lt>.
Hi,
It must not be problems for bacward compatibility in 1.0 release.
It is good to have more test cases, but it JXPath is some kind of frontend
implementation and 8 testcases is not so bad for this kind of code.


> pff hope you understand my english ;((.. Hope it is all clear what I
> meant though ..
>
> Mvgr,
> Martin
>
> On Sun, 2002-06-16 at 16:35, Martin van den Bemt wrote:
> > I will not -1 it, but hear me out ;)
> > I don't know jxpath (seen it around though), but just took a look at the
> > sourcecode.
> > It has about 8 testcases and that is a huge difference with the actual
> > number of classes in the jxpath package.
> > How can you asure that in the next release current behaviour is not
> > breaking bacward compatibility, except for the fact that you can say "I
> > seen it work" ? And of course the current release can have many bugs,
> > which can only be revealed in testcases (not saying it is, don't get me
> > wrong..)
> >
> > Mvgr,
> > Martin
> >
>
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [VOTE] Release vote for JXPath 1.0

Posted by Martin van den Bemt <ml...@mvdb.net>.
pff hope you understand my english ;((.. Hope it is all clear what I
meant though ..

Mvgr,
Martin

On Sun, 2002-06-16 at 16:35, Martin van den Bemt wrote:
> I will not -1 it, but hear me out ;)
> I don't know jxpath (seen it around though), but just took a look at the
> sourcecode.
> It has about 8 testcases and that is a huge difference with the actual
> number of classes in the jxpath package. 
> How can you asure that in the next release current behaviour is not
> breaking bacward compatibility, except for the fact that you can say "I
> seen it work" ? And of course the current release can have many bugs,
> which can only be revealed in testcases (not saying it is, don't get me
> wrong..)
> 
> Mvgr,
> Martin
> 



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [VOTE] Release vote for JXPath 1.0

Posted by Martin van den Bemt <ml...@mvdb.net>.
I will not -1 it, but hear me out ;)
I don't know jxpath (seen it around though), but just took a look at the
sourcecode.
It has about 8 testcases and that is a huge difference with the actual
number of classes in the jxpath package. 
How can you asure that in the next release current behaviour is not
breaking bacward compatibility, except for the fact that you can say "I
seen it work" ? And of course the current release can have many bugs,
which can only be revealed in testcases (not saying it is, don't get me
wrong..)

Mvgr,
Martin

On Sun, 2002-06-16 at 16:19, Dmitri Plotnikov wrote:
> I'd like to call for a release vote on JXPath 1.0 .  It has been stable for
> a while, and there are no outstanding bugs against it.  All the goals we had
> initially stated for this release have been met.
> 
> The release candidate build is
> 
> http://jakarta.apache.org/builds/jakarta-commons/release/commons-jxpath/v1.0
> 
> +1 (this is my vote)
> 
> Thank you,
> 
> Dmitri
> 
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
> 
> 



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [VOTE] Release vote for JXPath 1.0

Posted by co...@covalent.net.
+1 ( as non-commiter ). 

I've looked at the code and seen it used, it is really cool. I wish
I had more time...

Costin


On Sun, 16 Jun 2002, Dmitri Plotnikov wrote:

> I'd like to call for a release vote on JXPath 1.0 .  It has been stable for
> a while, and there are no outstanding bugs against it.  All the goals we had
> initially stated for this release have been met.
> 
> The release candidate build is
> 
> http://jakarta.apache.org/builds/jakarta-commons/release/commons-jxpath/v1.0
> 
> +1 (this is my vote)
> 
> Thank you,
> 
> Dmitri
> 
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
> 
> 


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>