You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/09/21 13:35:53 UTC

[GitHub] [nifi] turcsanyip commented on pull request #6368: NIFI-10442: Create PutIceberg processor

turcsanyip commented on PR #6368:
URL: https://github.com/apache/nifi/pull/6368#issuecomment-1253722349

   @mark-bathori Thanks for the latest changes! I set my review comments resolved and also tested the file format property and V1 tables.
   
   I looked into the data conversion code and now there are 3 separate implementations for Avro, Parquet and ORC conversions using the "low level" Iceberg API to write these data files.
   However, in the Iceberg API there also exists `GenericRecord` implementation that could be used for the conversion. So we would convert NiFi's `Record` object to Iceberg's `GenericRecord` object once, and then Iceberg would convert `GenericRecord` to Avro, Parquet and ORC  because it already knows how to do that.
   It would mean a more robust and maintainable code on our side.
   Do you think it makes sense?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org