You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Peter Roßbach <pr...@objektpark.de> on 2010/07/08 18:02:26 UTC
Vote: Add Checkstyle roleset and make code cleanups!
Hi,
after the discussion about code style (http://tomcat.markmail.org/thread/2c7lkzmpcuxqpgjj
), I think that we must vote for this fix:
https://issues.apache.org/bugzilla/show_bug.cgi?id=49268
It includes a starting point for a very limited checkstyle ruleset.
+1: progressively introduce checkstyle with checks for which a
consensus exists (first TabSpacePolicy, @Version format)
0 : More discussion needed
-1: no checkstyle integration. Tomcat shoudn't have code style rules
Regards
Peter
Re: Vote: Add Checkstyle roleset and make code cleanups!
Posted by Remy Maucherat <re...@apache.org>.
On Thu, 2010-07-08 at 18:02 +0200, Peter Roßbach wrote:
> Hi,
>
> after the discussion about code style (http://tomcat.markmail.org/thread/2c7lkzmpcuxqpgjj
> ), I think that we must vote for this fix:
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=49268
> It includes a starting point for a very limited checkstyle ruleset.
>
> +1: progressively introduce checkstyle with checks for which a
> consensus exists (first TabSpacePolicy, @Version format)
> 0 : More discussion needed
> -1: no checkstyle integration. Tomcat shoudn't have code style rules
-1, but I'm not actually contributing to trunk, so I guess it's only an
opinion.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org