You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2023/01/16 11:09:43 UTC
[GitHub] [camel-quarkus] essobedo opened a new pull request, #4409: Ref #4407: js-dsl - Improve the interoperability with Java code
essobedo opened a new pull request, #4409:
URL: https://github.com/apache/camel-quarkus/pull/4409
fixes #4407
## Motivation
The JavaScript DSL already supports the native mode but it is really limited in terms of interoperability with Java code, the goal of this task is to improve the code to at least support the basic use cases available [in the Came code base](https://github.com/apache/camel/tree/camel-3.x/dsl/camel-js-dsl/src/test/resources/routes).
## Modifications:
* Add a filter to the build step `registerReflectiveClasses` to call it only in native mode
* Register the missing methods and fields for reflection allowing to be able to configure Camel components from a JavaScript resource
* Add missing Camel reflective classes
* Add implementation of the main functional interfaces to have a way to implement them in native mode
* Add a limitation note about the function `Java.extend` and how to work around it
* Changes the IT the same way as for the Java jOOR DSL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #4409: Ref #4407: js-dsl - Improve the interoperability with Java code
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged PR #4409:
URL: https://github.com/apache/camel-quarkus/pull/4409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4409: Ref #4407: js-dsl - Improve the interoperability with Java code
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #4409:
URL: https://github.com/apache/camel-quarkus/pull/4409#issuecomment-1387043326
I opened https://github.com/apache/camel-quarkus/issues/4418.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4409: Ref #4407: js-dsl - Improve the interoperability with Java code
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #4409:
URL: https://github.com/apache/camel-quarkus/pull/4409#issuecomment-1385455084
@essobedo Should we merge this? As per #4407, I guess the native part needs GraalVM instead of Mandrel, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4409: Ref #4407: js-dsl - Improve the interoperability with Java code
Posted by GitBox <gi...@apache.org>.
ppalaga commented on PR #4409:
URL: https://github.com/apache/camel-quarkus/pull/4409#issuecomment-1386885552
> Otherwise we end up in our previous situation where stuff gets broken and nobody notices.
+100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4409: Ref #4407: js-dsl - Improve the interoperability with Java code
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #4409:
URL: https://github.com/apache/camel-quarkus/pull/4409#issuecomment-1386606230
At the moment the native tests aren't being executed on the CI build. So we should open an issue to get that figured out (for the future). Otherwise we end up in our previous situation where stuff gets broken and nobody notices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] essobedo commented on pull request #4409: Ref #4407: js-dsl - Improve the interoperability with Java code
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #4409:
URL: https://github.com/apache/camel-quarkus/pull/4409#issuecomment-1385546799
As you probably have understood my goal at the end is to make Camel-K evolves to be able to write an integration in the language of my choice and still be able to compile it natively in order to save as much resources as possible to reduce the costs when deploying it on a public cloud.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] essobedo commented on pull request #4409: Ref #4407: js-dsl - Improve the interoperability with Java code
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #4409:
URL: https://github.com/apache/camel-quarkus/pull/4409#issuecomment-1385534177
@jamesnetherton good question, for me yes as it is still useable on GraalVM and personally I cannot imagine the Quarkus team enforcing the community to use Mandrel definitively just because of a bug that will be fixed one day or another. AFAIU, they only switch as long as the bug is open.
For me, the question is more, do you want to keep on proposing the js-DSL in native mode? If not, you can close it otherwise IMHO it is worth keeping it but it is only my point of view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org