[GitHub] [arrow] shefali163 commented on a diff in pull request #12914: ARROW-2034: [C++] Filesystem implementation for Azure Blob Storage

[GitBox <gi...@apache.org>]

shefali163 commented on code in PR #12914:
URL: https://github.com/apache/arrow/pull/12914#discussion_r898953832


##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -118,12 +118,16 @@ if(NOT DEFINED CMAKE_C_STANDARD)
   set(CMAKE_C_STANDARD 11)
 endif()
 
-# This ensures that things like c++11 get passed correctly
+# This ensures that things like c++11/c++14 get passed correctly
 if(NOT DEFINED CMAKE_CXX_STANDARD)
-  set(CMAKE_CXX_STANDARD 11)
+  if(ARROW_AZURE)
+    set(CMAKE_CXX_STANDARD 14)

Review Comment:
   Is it possible to set `CMAKE_CXX_STANDARD` to 14 only for the Azure component given that `azurefs.cc`/`azurefs_test.cc` is a part of the Arrow target? If we make a separate target for compiling Azure files then it might be possible to use `set_target_properties(azurefs_objlib PROPERTIES CXX_STANDARD 14 CXX_STANDARD_REQUIRED ON)`. Initially, we had a separate Azure target but this change was suggested by @kou



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org