[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

[GitBox <gi...@apache.org>]

thomasmueller commented on code in PR #679:
URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r961500375


##########
oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneFacetCommonTest.java:
##########
@@ -46,13 +44,6 @@ protected Repository createJcrRepository() {
         return jcr.createRepository();
     }
 
-    @Override
-    @Test
-    @Ignore("failing in lucene only, needs more investigation")

Review Comment:
    🤦‍♂️  (facepalm)



##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticDocumentMaker.java:
##########
@@ -53,7 +53,8 @@ protected ElasticDocument initDoc() {
 
     @Override
     protected ElasticDocument finalizeDoc(ElasticDocument doc, boolean dirty, boolean facet) {
-        // evaluate path restrictions is enabled by default in elastic. Always index ancestors
+        // Evaluate path restrictions is enabled by default in elastic. Always index ancestors.
+        // When specifically disabled, we will keep indexing it, but the field won't be used at query time

Review Comment:
   Yes it makes sense.
   
   We could make it less silent... e.g. log a warning... but for compatibility reasons, we can't currently can't throw an exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org