You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Hubert Rabago <ja...@yahoo.com> on 2004/02/02 20:10:36 UTC
Bug 866 patches
Ted,
Not sure if it mattered, but I used "diff -u -b" for the patches I submitted.
I found out that my editor trimmed a lot of lines that only had spaces, and
so the diffs I initially generated caught all of them. The ones I eventually
submitted didn't have the whitespace changes.
Also, the method I added to the RequestProcessor is being tested in
TestActionRedirect. There's no TestRequestProcessor class (yet). If I
created one to test one method, it might give someone else the impression
that the whole class was being tested.
- Hubert
Hubert
__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free web site building tool. Try it!
http://webhosting.yahoo.com/ps/sb/
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Bug 866 patches
Posted by Joe Germuska <Jo...@Germuska.com>.
At 11:10 AM -0800 2/2/04, Hubert Rabago wrote:
>Ted,
>
>Not sure if it mattered, but I used "diff -u -b" for the patches I submitted.
> I found out that my editor trimmed a lot of lines that only had spaces, and
>so the diffs I initially generated caught all of them. The ones I eventually
>submitted didn't have the whitespace changes.
>
>Also, the method I added to the RequestProcessor is being tested in
>TestActionRedirect. There's no TestRequestProcessor class (yet). If I
>created one to test one method, it might give someone else the impression
>that the whole class was being tested.
Or it might encourage someone else to write tests for other methods,
since the "ice" would have been "broken"!
Don't let impressions bother you. With tests, any are better than none.
Joe
--
Joe Germuska
Joe@Germuska.com
http://blog.germuska.com
"Imagine if every Thursday your shoes exploded if you tied them
the usual way. This happens to us all the time with computers, and
nobody thinks of complaining."
-- Jef Raskin
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org