You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/09/27 04:21:28 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #43141: [SPARK-44034][TESTS][3.4] Add a new test group for sql module

LuciferYang commented on code in PR #43141:
URL: https://github.com/apache/spark/pull/43141#discussion_r1338023773


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala:
##########
@@ -220,7 +220,8 @@ class QueryExecutionSuite extends SharedSparkSession {
     assertNoTag(tag5, df.queryExecution.sparkPlan)
   }
 
-  test("Logging plan changes for execution") {
+  // TODO(SPARK-44074): re-enable this test after SPARK-44074 resolved
+  ignore("Logging plan changes for execution") {

Review Comment:
   After this PR, we need to backport the changes of SPARK-44074 to branch-3.4 to re-enable this case.
   
   Can the changes of SPARK-44074 be merged into the current PR?
   
   For the branch-3.3, I will submit pr later. Afterwards, the `build_and_test.yml` of the master branch also needs to be fixed to let the daily test use these tags.
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org