You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2008/05/30 10:37:45 UTC
[jira] Created: (THRIFT-30) RPM .spec file for Thrift
RPM .spec file for Thrift
-------------------------
Key: THRIFT-30
URL: https://issues.apache.org/jira/browse/THRIFT-30
Project: Thrift
Issue Type: New Feature
Reporter: David Reiss
Assignee: David Reiss
RPM .spec file, plus a few other small changes:
http://thrift-git.thruhere.net/gitweb/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fc9;hb=dd0e19a
Ben, can you review?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-30) RPM .spec file for Thrift
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-30.
-------------------------------
Resolution: Fixed
> RPM .spec file for Thrift
> -------------------------
>
> Key: THRIFT-30
> URL: https://issues.apache.org/jira/browse/THRIFT-30
> Project: Thrift
> Issue Type: New Feature
> Reporter: David Reiss
> Assignee: David Reiss
>
> RPM .spec file, plus a few other small changes:
> http://thrift-git.thruhere.net/gitweb/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fc9;hb=dd0e19a
> Ben, can you review?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-30) RPM .spec file for Thrift
Posted by "Ben Maurer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601329#action_12601329 ]
Ben Maurer commented on THRIFT-30:
----------------------------------
lgtm
> RPM .spec file for Thrift
> -------------------------
>
> Key: THRIFT-30
> URL: https://issues.apache.org/jira/browse/THRIFT-30
> Project: Thrift
> Issue Type: New Feature
> Reporter: David Reiss
> Assignee: David Reiss
>
> RPM .spec file, plus a few other small changes:
> http://thrift-git.thruhere.net/gitweb/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fc9;hb=dd0e19a
> Ben, can you review?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-30) RPM .spec file for Thrift
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601320#action_12601320 ]
David Reiss commented on THRIFT-30:
-----------------------------------
Regarding zlib, I see no need to make it a requirement, especially since few people use the zlib transport. Maybe it is just my Gentoo experience.
Regarding libevent, no I haven't. I just lifted that requirement out of your original .spec. :)
Regarding pkg-config, will fix. Regarding, .so symlinks. It looks like you are mostly right. I'll fix it to look like some Fedora packages I checked out.
Regarding boost, I have no idea. Let's wait for a bug report. :)
I'll try to fill in some more explicit dependencies.
> RPM .spec file for Thrift
> -------------------------
>
> Key: THRIFT-30
> URL: https://issues.apache.org/jira/browse/THRIFT-30
> Project: Thrift
> Issue Type: New Feature
> Reporter: David Reiss
> Assignee: David Reiss
>
> RPM .spec file, plus a few other small changes:
> http://thrift-git.thruhere.net/gitweb/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fc9;hb=dd0e19a
> Ben, can you review?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-30) RPM .spec file for Thrift
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601328#action_12601328 ]
David Reiss commented on THRIFT-30:
-----------------------------------
Oh, and with respect to Paul's question, I could go either way. I went with Thrift because we haven't finished the import process yet.
> RPM .spec file for Thrift
> -------------------------
>
> Key: THRIFT-30
> URL: https://issues.apache.org/jira/browse/THRIFT-30
> Project: Thrift
> Issue Type: New Feature
> Reporter: David Reiss
> Assignee: David Reiss
>
> RPM .spec file, plus a few other small changes:
> http://thrift-git.thruhere.net/gitweb/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fc9;hb=dd0e19a
> Ben, can you review?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-30) RPM .spec file for Thrift
Posted by "Paul Saab (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601044#action_12601044 ]
Paul Saab commented on THRIFT-30:
---------------------------------
Should Thrift still be under the Thrift Source License or should it be migrating to the Apache License?
> RPM .spec file for Thrift
> -------------------------
>
> Key: THRIFT-30
> URL: https://issues.apache.org/jira/browse/THRIFT-30
> Project: Thrift
> Issue Type: New Feature
> Reporter: David Reiss
> Assignee: David Reiss
>
> RPM .spec file, plus a few other small changes:
> http://thrift-git.thruhere.net/gitweb/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fc9;hb=dd0e19a
> Ben, can you review?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-30) RPM .spec file for Thrift
Posted by "Ben Maurer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601317#action_12601317 ]
Ben Maurer commented on THRIFT-30:
----------------------------------
26 %if %{!?without_zlib: 1}
27 BuildRequires: zlib-devel
28 %endif
Without *zlib*. I think it's safe to make this always required.
22 %if %{!?without_libevent: 1}
23 BuildRequires: libevent-devel >= 1.2
24 %endif
25
Have you tested with the older version?
68 %{_libdir}/libthrift*.so*
69 %{_libdir}/pkgconfig/thrift*.pc
The .so symlinks and pc file should go into the devel package.
20 BuildRequires: boost-devel
Which version?
- I think you may need to add some more explicit dependencies for non-c things. Eg, the python package should depend on python at runtime. The c++ devel package probably needs to depend on all of the devel packages in BuildRequires. Also, if I remember correcty, it's a best practice to have devel packages depend on the exact version of the corresponding non-devel package. That way, if you upgrade the non-devel package, the devel gets pulled in too.
> RPM .spec file for Thrift
> -------------------------
>
> Key: THRIFT-30
> URL: https://issues.apache.org/jira/browse/THRIFT-30
> Project: Thrift
> Issue Type: New Feature
> Reporter: David Reiss
> Assignee: David Reiss
>
> RPM .spec file, plus a few other small changes:
> http://thrift-git.thruhere.net/gitweb/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fc9;hb=dd0e19a
> Ben, can you review?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-30) RPM .spec file for Thrift
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601326#action_12601326 ]
David Reiss commented on THRIFT-30:
-----------------------------------
Updated (same link). I didn't add the Python dependencies because two Python packages I picked at random from the fedora repo didn't have them.
> RPM .spec file for Thrift
> -------------------------
>
> Key: THRIFT-30
> URL: https://issues.apache.org/jira/browse/THRIFT-30
> Project: Thrift
> Issue Type: New Feature
> Reporter: David Reiss
> Assignee: David Reiss
>
> RPM .spec file, plus a few other small changes:
> http://thrift-git.thruhere.net/gitweb/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fc9;hb=dd0e19a
> Ben, can you review?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.