You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by matzew <gi...@git.apache.org> on 2017/06/19 12:44:30 UTC

[GitHub] kafka pull request #3370: making util classes final and adding private ctor

GitHub user matzew opened a pull request:

    https://github.com/apache/kafka/pull/3370

    making util classes final and adding private ctor

    Utils with static methods should not be instantiated, hence marking the classes `final` and adding a `private` constructor.
    
    this is consistent w/ some of the Util classes, such as `ByteUtils`, see:
    https://github.com/apache/kafka/blob/d345d53e4e5e4f74707e2521aa635b93ba3f1e7b/clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java#L29-L31

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matzew/kafka utils_improvment

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3370
    
----
commit 633fa03ab04df3a3e9ed48d4401828e1d969a5a5
Author: Matthias Wessendorf <ma...@apache.org>
Date:   2017-06-19T12:42:44Z

    making util classes final and adding private ctor

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---