You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2008/04/25 19:35:55 UTC
[jira] Created: (HADOOP-3313) RPC::Invoker makes unnecessary calls
to System.currentTimeMillis
RPC::Invoker makes unnecessary calls to System.currentTimeMillis
-----------------------------------------------------------------
Key: HADOOP-3313
URL: https://issues.apache.org/jira/browse/HADOOP-3313
Project: Hadoop Core
Issue Type: Bug
Reporter: Chris Douglas
Priority: Minor
RPC::Invoker::invoke(...) makes two calls to System.curentTimeMillis(), but discards the result if debug logging is disabled (as it almost always will be).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3313) RPC::Invoker makes unnecessary
calls to System.currentTimeMillis
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592566#action_12592566 ]
Hudson commented on HADOOP-3313:
--------------------------------
Integrated in Hadoop-trunk #471 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/471/])
> RPC::Invoker makes unnecessary calls to System.currentTimeMillis
> -----------------------------------------------------------------
>
> Key: HADOOP-3313
> URL: https://issues.apache.org/jira/browse/HADOOP-3313
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3313-0.patch
>
>
> RPC::Invoker::invoke(...) makes two calls to System.curentTimeMillis(), but discards the result if debug logging is disabled (as it almost always will be).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3313) RPC::Invoker makes unnecessary calls
to System.currentTimeMillis
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3313:
----------------------------------
Assignee: Chris Douglas
Status: Patch Available (was: Open)
> RPC::Invoker makes unnecessary calls to System.currentTimeMillis
> -----------------------------------------------------------------
>
> Key: HADOOP-3313
> URL: https://issues.apache.org/jira/browse/HADOOP-3313
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Attachments: 3313-0.patch
>
>
> RPC::Invoker::invoke(...) makes two calls to System.curentTimeMillis(), but discards the result if debug logging is disabled (as it almost always will be).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3313) RPC::Invoker makes unnecessary calls
to System.currentTimeMillis
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3313:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.18.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this
> RPC::Invoker makes unnecessary calls to System.currentTimeMillis
> -----------------------------------------------------------------
>
> Key: HADOOP-3313
> URL: https://issues.apache.org/jira/browse/HADOOP-3313
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3313-0.patch
>
>
> RPC::Invoker::invoke(...) makes two calls to System.curentTimeMillis(), but discards the result if debug logging is disabled (as it almost always will be).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3313) RPC::Invoker makes unnecessary
calls to System.currentTimeMillis
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592470#action_12592470 ]
Hadoop QA commented on HADOOP-3313:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380958/3313-0.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2329/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2329/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2329/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2329/console
This message is automatically generated.
> RPC::Invoker makes unnecessary calls to System.currentTimeMillis
> -----------------------------------------------------------------
>
> Key: HADOOP-3313
> URL: https://issues.apache.org/jira/browse/HADOOP-3313
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Attachments: 3313-0.patch
>
>
> RPC::Invoker::invoke(...) makes two calls to System.curentTimeMillis(), but discards the result if debug logging is disabled (as it almost always will be).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3313) RPC::Invoker makes unnecessary
calls to System.currentTimeMillis
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592472#action_12592472 ]
Raghu Angadi commented on HADOOP-3313:
--------------------------------------
+1. Good catch.
> RPC::Invoker makes unnecessary calls to System.currentTimeMillis
> -----------------------------------------------------------------
>
> Key: HADOOP-3313
> URL: https://issues.apache.org/jira/browse/HADOOP-3313
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Attachments: 3313-0.patch
>
>
> RPC::Invoker::invoke(...) makes two calls to System.curentTimeMillis(), but discards the result if debug logging is disabled (as it almost always will be).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3313) RPC::Invoker makes unnecessary calls
to System.currentTimeMillis
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3313:
----------------------------------
Attachment: 3313-0.patch
> RPC::Invoker makes unnecessary calls to System.currentTimeMillis
> -----------------------------------------------------------------
>
> Key: HADOOP-3313
> URL: https://issues.apache.org/jira/browse/HADOOP-3313
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Priority: Minor
> Attachments: 3313-0.patch
>
>
> RPC::Invoker::invoke(...) makes two calls to System.curentTimeMillis(), but discards the result if debug logging is disabled (as it almost always will be).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.