You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/15 08:36:51 UTC
Review Request 24734: Fixed a few issues in configure.ac.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/
-----------------------------------------------------------
Review request for mesos, Timothy St. Clair and Vinod Kone.
Repository: mesos-git
Description
-------
Merged the fix in https://reviews.apache.org/r/24714/
Fixed a few other issues.
Also, did a few consistency/style fix.
Diffs
-----
3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634
configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
Diff: https://reviews.apache.org/r/24734/diff/
Testing
-------
On my mac:
CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
Thanks,
Jie Yu
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50722
-----------------------------------------------------------
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/24734/#comment88584>
We could add a LIB check, but it's not critical at this point.
- Timothy St. Clair
On Aug. 15, 2014, 6:36 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 6:36 a.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50708
-----------------------------------------------------------
Ship it!
LGTM. I'll let Tim give it a look over.
- Vinod Kone
On Aug. 15, 2014, 6:36 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 6:36 a.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 15, 2014, 2:23 p.m., Timothy St. Clair wrote:
> > configure.ac, line 283
> > <https://reviews.apache.org/r/24734/diff/1/?file=661315#file661315line283>
> >
> > This needs to be here or else the includes fail on distributions.
>
> Jie Yu wrote:
> Are you saying that I should do:
>
> CPPFLAGS="$CPPFLAGS -I/usr/include" here?
>
> Is that the default? I'm curious what the error is?
The build fails on zookeeper.h includes inside of the mesos srouce. b/c the -I path is only /usr/include and zookeeper lives under '/usr/include/zookeeper'
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50719
-----------------------------------------------------------
On Aug. 15, 2014, 6:36 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 6:36 a.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 15, 2014, 2:23 p.m., Timothy St. Clair wrote:
> > configure.ac, line 283
> > <https://reviews.apache.org/r/24734/diff/1/?file=661315#file661315line283>
> >
> > This needs to be here or else the includes fail on distributions.
Are you saying that I should do:
CPPFLAGS="$CPPFLAGS -I/usr/include" here?
Is that the default? I'm curious what the error is?
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50719
-----------------------------------------------------------
On Aug. 15, 2014, 6:36 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 6:36 a.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50719
-----------------------------------------------------------
Thanks for all the help guys! & That is an epic configure line ;-)
We need to be careful here, b/c even if they can build, their runtime will need to overload LD_LIBRARY_PATH to point to all the separte locations, and make sure that doesn't muck with other applications. (recommend chroots where possible.)
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/24734/#comment88581>
Don't we need LD_FLAGS here, as Vinod mentioned.
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/24734/#comment88582>
Switching this check will cause linkage failure on the tests for pure --disable-bundled. It will not affect --prefix installations so I would not change this one, it's a distribution only constraint at this point.
configure.ac
<https://reviews.apache.org/r/24734/#comment88583>
This needs to be here or else the includes fail on distributions.
- Timothy St. Clair
On Aug. 15, 2014, 6:36 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 6:36 a.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 111
> > <https://reviews.apache.org/r/24734/diff/3/?file=661496#file661496line111>
> >
> > should this be --with-http_parser? "_" between http and parser.
>
> Timothy St. Clair wrote:
> why?
>
> $ sudo yum list | grep http | grep parse
> http-parser.x86_64 2.0-5.20121128gitcd01361.fc20 @fedora
> http-parser-devel.x86_64 2.0-5.20121128gitcd01361.fc20 @fedora
oh, because the test below "if test -n "`echo $with_http_parser`" changed the dash to underscore. i guess that works because of autotools magic?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50751
-----------------------------------------------------------
On Aug. 15, 2014, 5:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 5:19 p.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
> src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c
> src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f
> src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12
> src/zookeeper/authentication.hpp 7b6b767b1451bb361c0c26675b642a072f6e5103
> src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 425
> > <https://reviews.apache.org/r/24734/diff/3/?file=661496#file661496line425>
> >
> > I'm little confused on what the difference is between PROTOCOMPILER vs PROTOBUF_COMPILER vs PROTOC. can we consolidate?
It's strictly to prefent name collisions..
PROTOBUF_COMPILER could probably be PROTOBUF_COMPILER_TEST.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50751
-----------------------------------------------------------
On Aug. 15, 2014, 5:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 5:19 p.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
> src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c
> src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f
> src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12
> src/zookeeper/authentication.hpp 7b6b767b1451bb361c0c26675b642a072f6e5103
> src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 111
> > <https://reviews.apache.org/r/24734/diff/3/?file=661496#file661496line111>
> >
> > should this be --with-http_parser? "_" between http and parser.
>
> Timothy St. Clair wrote:
> why?
>
> $ sudo yum list | grep http | grep parse
> http-parser.x86_64 2.0-5.20121128gitcd01361.fc20 @fedora
> http-parser-devel.x86_64 2.0-5.20121128gitcd01361.fc20 @fedora
>
> Vinod Kone wrote:
> oh, because the test below "if test -n "`echo $with_http_parser`" changed the dash to underscore. i guess that works because of autotools magic?
autotool will replace - with _
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote:
> > src/zookeeper/zookeeper.hpp, lines 36-38
> > <https://reviews.apache.org/r/24734/diff/3/?file=661502#file661502line36>
> >
> > reorder.
I've revert this change since it does not work with our bundled zk.
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote:
> > configure.ac, line 412
> > <https://reviews.apache.org/r/24734/diff/3/?file=661497#file661497line412>
> >
> > shouldn't this be "$PROTOBUFPREFIX/bin" because that's what AC_CHECK_TOOL is checking below?
AC_CHECK_TOOL will search PATH. the last argument is the PATH.
I.e., we are searching protoc command under prefix/bin
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 425
> > <https://reviews.apache.org/r/24734/diff/3/?file=661496#file661496line425>
> >
> > I'm little confused on what the difference is between PROTOCOMPILER vs PROTOBUF_COMPILER vs PROTOC. can we consolidate?
>
> Timothy St. Clair wrote:
> It's strictly to prefent name collisions..
>
> PROTOBUF_COMPILER could probably be PROTOBUF_COMPILER_TEST.
Consolidated.
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 423
> > <https://reviews.apache.org/r/24734/diff/3/?file=661496#file661496line423>
> >
> > maybe the error here could also say "please set PROTOBUF_JAR environment variable" ?
Hum, user might set the environment variable, but a wrong path. I prefer keep the existing:)
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50751
-----------------------------------------------------------
On Aug. 15, 2014, 5:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 5:19 p.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
> src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c
> src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f
> src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12
> src/zookeeper/authentication.hpp 7b6b767b1451bb361c0c26675b642a072f6e5103
> src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 111
> > <https://reviews.apache.org/r/24734/diff/3/?file=661496#file661496line111>
> >
> > should this be --with-http_parser? "_" between http and parser.
why?
$ sudo yum list | grep http | grep parse
http-parser.x86_64 2.0-5.20121128gitcd01361.fc20 @fedora
http-parser-devel.x86_64 2.0-5.20121128gitcd01361.fc20 @fedora
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50751
-----------------------------------------------------------
On Aug. 15, 2014, 5:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 5:19 p.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
> src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c
> src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f
> src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12
> src/zookeeper/authentication.hpp 7b6b767b1451bb361c0c26675b642a072f6e5103
> src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50751
-----------------------------------------------------------
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/24734/#comment88607>
should this be --with-http_parser? "_" between http and parser.
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/24734/#comment88604>
maybe the error here could also say "please set PROTOBUF_JAR environment variable" ?
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/24734/#comment88611>
I'm little confused on what the difference is between PROTOCOMPILER vs PROTOBUF_COMPILER vs PROTOC. can we consolidate?
configure.ac
<https://reviews.apache.org/r/24734/#comment88610>
shouldn't this be "$PROTOBUFPREFIX/bin" because that's what AC_CHECK_TOOL is checking below?
src/zookeeper/zookeeper.hpp
<https://reviews.apache.org/r/24734/#comment88603>
reorder.
- Vinod Kone
On Aug. 15, 2014, 5:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 5:19 p.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
> src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c
> src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f
> src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12
> src/zookeeper/authentication.hpp 7b6b767b1451bb361c0c26675b642a072f6e5103
> src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50772
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy St. Clair
On Aug. 15, 2014, 6:58 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 6:58 p.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
> src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c
> src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f
> src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50769
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 15, 2014, 6:58 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 6:58 p.m.)
>
>
> Review request for mesos, Timothy St. Clair and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged the fix in https://reviews.apache.org/r/24714/
>
> Fixed a few other issues.
>
> Also, did a few consistency/style fix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6
> configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
> src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c
> src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f
> src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12
>
> Diff: https://reviews.apache.org/r/24734/diff/
>
>
> Testing
> -------
>
> On my mac:
>
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 6:58 p.m.)
Review request for mesos, Timothy St. Clair and Vinod Kone.
Changes
-------
Review comments.
Repository: mesos-git
Description
-------
Merged the fix in https://reviews.apache.org/r/24714/
Fixed a few other issues.
Also, did a few consistency/style fix.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6
configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c
src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f
src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12
Diff: https://reviews.apache.org/r/24734/diff/
Testing
-------
On my mac:
CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
Thanks,
Jie Yu
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 5:19 p.m.)
Review request for mesos, Timothy St. Clair and Vinod Kone.
Changes
-------
Rebased off master.
Repository: mesos-git
Description
-------
Merged the fix in https://reviews.apache.org/r/24714/
Fixed a few other issues.
Also, did a few consistency/style fix.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6
configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c
src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f
src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12
src/zookeeper/authentication.hpp 7b6b767b1451bb361c0c26675b642a072f6e5103
src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b
Diff: https://reviews.apache.org/r/24734/diff/
Testing
-------
On my mac:
CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
Thanks,
Jie Yu
Re: Review Request 24734: Fixed a few issues in configure.ac.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 5:12 p.m.)
Review request for mesos, Timothy St. Clair and Vinod Kone.
Changes
-------
Tim's comments. Tested on Linux with default ./configure.
Repository: mesos-git
Description
-------
Merged the fix in https://reviews.apache.org/r/24714/
Fixed a few other issues.
Also, did a few consistency/style fix.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634
configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c
src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c
src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f
src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12
src/zookeeper/authentication.hpp 7b6b767b1451bb361c0c26675b642a072f6e5103
src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b
Diff: https://reviews.apache.org/r/24734/diff/
Testing
-------
On my mac:
CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser
Thanks,
Jie Yu