[GitHub] [pinot] shenyu0127 commented on pull request #11188: Fail the query when IN or NOT IN filter contains NULL.

["shenyu0127 (via GitHub)" <gi...@apache.org>]

shenyu0127 commented on PR #11188:
URL: https://github.com/apache/pinot/pull/11188#issuecomment-1654503145

   > @shenyu0127 : can you share what was the previous behavior was for these queries?
   
   The previous behavior was to throw a different error from segment pruning: 
   Currently the query `SELECT * FROM airlineStats WHERE AirTime IN (1, 2, null)` gets the following error
   ```
   [
     {
       "errorCode": 200,
       "message": "QueryExecutionError:\norg.apache.pinot.spi.exception.BadQueryRequestException: java.lang.IllegalArgumentException: Cannot convert value: 'null' to type: INT\n\tat org.apache.pinot.core.query.pruner.ValueBasedSegmentPruner.convertValue(ValueBasedSegmentPruner.java:157)\n\tat org.apache.pinot.core.query.pruner.ValueBasedSegmentPruner$ValueCache$CachedValue.ensureDataType(ValueBasedSegmentPruner.java:223)\n\tat org.apache.pinot.core.query.pruner.ValueBasedSegmentPruner$ValueCache.get(ValueBasedSegmentPruner.java:197)\n\tat org.apache.pinot.core.query.pruner.ColumnValueSegmentPruner.pruneInPredicate(ColumnValueSegmentPruner.java:147)\n...\nCaused by: java.lang.IllegalArgumentException: Cannot convert value: 'null' to type: INT\n\tat org.apache.pinot.spi.data.FieldSpec$DataType.convertInternal(FieldSpec.java:565)\n\tat org.apache.pinot.core.query.pruner.ValueBasedSegmentPruner.convertValue(ValueBasedSegmentPruner.java:155)\n\t... 22 more"
     }
   ]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org