You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Guillaume Nodet <gn...@apache.org> on 2017/02/10 07:43:40 UTC
[DISCUSS] Release resolver 1.10.2
I'd like to get FELIX-5450 and FELIX-5514 out of the door, so unless
someone volunteer to do the resolver 1.10.2 release, i'll give it a try
next week.
Cheers,
Guillaume
Re: [DISCUSS] Release resolver 1.10.2
Posted by Thomas Watson <tj...@gmail.com>.
+1
Also notice that I fixed resolver issue
https://issues.apache.org/jira/browse/FELIX-5514 which should get released
also
Tom.
On Feb 10, 2017 8:19 AM, "David Bosschaert" <da...@gmail.com>
wrote:
> That would be great, thanks Guillaume!
>
> David
>
> On 9 February 2017 at 23:43, Guillaume Nodet <gn...@apache.org> wrote:
>
> > I'd like to get FELIX-5450 and FELIX-5514 out of the door, so unless
> > someone volunteer to do the resolver 1.10.2 release, i'll give it a try
> > next week.
> >
> > Cheers,
> > Guillaume
> >
>
Re: [DISCUSS] Release resolver 1.10.2
Posted by David Bosschaert <da...@gmail.com>.
That would be great, thanks Guillaume!
David
On 9 February 2017 at 23:43, Guillaume Nodet <gn...@apache.org> wrote:
> I'd like to get FELIX-5450 and FELIX-5514 out of the door, so unless
> someone volunteer to do the resolver 1.10.2 release, i'll give it a try
> next week.
>
> Cheers,
> Guillaume
>
Re: [DISCUSS] Release resolver 1.10.2
Posted by Karl Pauls <ka...@gmail.com>.
I just did this as part of FELIX-5547. With that and FELIX-5544 out of
the way I'm now going to try to get FELIX-5329 done.
When I have that finished and assuming nothing else pops-up I'm going
to cut a resolver and a framework release (hopefully tomorrow).
regards,
Karl
On Tue, Feb 14, 2017 at 4:37 PM, Karl Pauls <ka...@gmail.com> wrote:
> Well, I guess I don't even have to make the method public - I'm just
> going to copy it over to the framework if need be until we have a
> better way.
>
> With that out of the way, do you think the resolver is good to go for a release?
>
> regards,
>
> Karl
>
> On Tue, Feb 14, 2017 at 4:24 PM, Karl Pauls <ka...@gmail.com> wrote:
>>> That is currently a private static method. If the Felix framework does not
>>> already have the substitution wire information available then we can
>>> consider making this static method public so you can call it from your
>>> FelixResolveContext implementation. But I think if you don't already have
>>> this information calculated for resolved wirings then you likely have a bug
>>> in require-bundle class loader delegation.
>>
>> Afaik, we don't have this info readily available as we keep track of
>> this in a different way (I'll double-check with Richard).
>>
>> If not, I still would like to get a combined resolver and framework
>> release done this week so assuming I make the method public and
>> delegate to it from the framework do you think there is anything else
>> that would prevent us from doing a resolver and framework release?
>>
>> regards,
>>
>> Karl
>>
>>> My hope is that in a future OSGi Resolver specification the ResolveContext
>>> API from OSGi will contain updates that make the FelixResolveContext
>>> interface obsolete. For example, the proposed updates for the R7 resolver
>>> already remove the need for the method
>>> FelixResolveContext.getOndemandResources(Resource).
>>>
>>> Tom.
>>>
>>>
>>> On Mon, Feb 13, 2017 at 10:13 AM, Pierre De Rop <pi...@gmail.com>
>>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> I also would like to do a test with the latest framework and resolver from
>>>> the trunk, but it looks like there is a compilation issue with the
>>>> framework (trunk):
>>>>
>>>> I have rebuilt the resolver, then the framework, and I'm having this error:
>>>>
>>>> [ERROR]
>>>> /tmp/xx/framework/src/main/java/org/apache/felix/
>>>> framework/ResolveContextImpl.java:[44,8]
>>>> org.apache.felix.framework.ResolveContextImpl is not abstract and does not
>>>> override abstract method getSubstitutionWires(org.osgi.resource.Wiring) in
>>>> org.apache.felix.resolver.FelixResolveContext
>>>>
>>>> can someone please check this ?
>>>>
>>>> I just came across a NPE in the resolver using framework 5.6.1 and I would
>>>> like to check if I'm also having it with the latest resolver from the
>>>> trunk; thank you.
>>>>
>>>> best regards
>>>> /Pierre
>>>>
>>>>
>>>> On Mon, Feb 13, 2017 at 10:48 AM, Guillaume Nodet <gn...@apache.org>
>>>> wrote:
>>>>
>>>> > Great !
>>>> > Let me know if you need any help...
>>>> >
>>>> > Cheers,
>>>> > Guillaume
>>>> >
>>>> > 2017-02-10 12:53 GMT+01:00 Karl Pauls <ka...@gmail.com>:
>>>> >
>>>> > > I can do the release next week if you don't mind, as I was planning to
>>>> > > do a framework release anyhow (almost done with FELIX-5528 - just need
>>>> > > a bit more testing).
>>>> > >
>>>> > > regards,
>>>> > >
>>>> > > Karl
>>>> > >
>>>> > > On Fri, Feb 10, 2017 at 8:43 AM, Guillaume Nodet <gn...@apache.org>
>>>> > > wrote:
>>>> > > > I'd like to get FELIX-5450 and FELIX-5514 out of the door, so unless
>>>> > > > someone volunteer to do the resolver 1.10.2 release, i'll give it a
>>>> > try
>>>> > > > next week.
>>>> > > >
>>>> > > > Cheers,
>>>> > > > Guillaume
>>>> > >
>>>> > >
>>>> > >
>>>> > > --
>>>> > > Karl Pauls
>>>> > > karlpauls@gmail.com
>>>> > >
>>>> >
>>>> >
>>>> >
>>>> > --
>>>> > ------------------------
>>>> > Guillaume Nodet
>>>> >
>>>>
>>
>>
>>
>> --
>> Karl Pauls
>> karlpauls@gmail.com
>
>
>
> --
> Karl Pauls
> karlpauls@gmail.com
--
Karl Pauls
karlpauls@gmail.com
Re: [DISCUSS] Release resolver 1.10.2
Posted by Karl Pauls <ka...@gmail.com>.
Sounds like we have to (and can, as it is no regression) push
FELIX-5548 to a later release.
As I'm done with the issue I had (except maybe FELIX-5548 which I
still have to figure out when it happens) I'll cut a release of the
resolver and the framework either tonight or tomorrow.
regards,
Karl
On Tue, Feb 14, 2017 at 6:25 PM, Karl Pauls <ka...@gmail.com> wrote:
> Ok, can you or somebody else have a look at FELIX-5548 and see if that
> is a blocker for a resolver release or no?
>
> regards,
>
> karl
>
> On Tue, Feb 14, 2017 at 5:59 PM, Thomas Watson <tj...@gmail.com> wrote:
>> Yes, the resolver is ready to release.
>>
>> Tom
>>
>> On Tue, Feb 14, 2017 at 9:37 AM, Karl Pauls <ka...@gmail.com> wrote:
>>
>>> Well, I guess I don't even have to make the method public - I'm just
>>> going to copy it over to the framework if need be until we have a
>>> better way.
>>>
>>> With that out of the way, do you think the resolver is good to go for a
>>> release?
>>>
>>> regards,
>>>
>>> Karl
>>>
>>> On Tue, Feb 14, 2017 at 4:24 PM, Karl Pauls <ka...@gmail.com> wrote:
>>> >> That is currently a private static method. If the Felix framework does
>>> not
>>> >> already have the substitution wire information available then we can
>>> >> consider making this static method public so you can call it from your
>>> >> FelixResolveContext implementation. But I think if you don't already
>>> have
>>> >> this information calculated for resolved wirings then you likely have a
>>> bug
>>> >> in require-bundle class loader delegation.
>>> >
>>> > Afaik, we don't have this info readily available as we keep track of
>>> > this in a different way (I'll double-check with Richard).
>>> >
>>> > If not, I still would like to get a combined resolver and framework
>>> > release done this week so assuming I make the method public and
>>> > delegate to it from the framework do you think there is anything else
>>> > that would prevent us from doing a resolver and framework release?
>>> >
>>> > regards,
>>> >
>>> > Karl
>>> >
>>> >> My hope is that in a future OSGi Resolver specification the
>>> ResolveContext
>>> >> API from OSGi will contain updates that make the FelixResolveContext
>>> >> interface obsolete. For example, the proposed updates for the R7
>>> resolver
>>> >> already remove the need for the method
>>> >> FelixResolveContext.getOndemandResources(Resource).
>>> >>
>>> >> Tom.
>>> >>
>>> >>
>>> >> On Mon, Feb 13, 2017 at 10:13 AM, Pierre De Rop <pierre.derop@gmail.com
>>> >
>>> >> wrote:
>>> >>
>>> >>> Hi All,
>>> >>>
>>> >>> I also would like to do a test with the latest framework and resolver
>>> from
>>> >>> the trunk, but it looks like there is a compilation issue with the
>>> >>> framework (trunk):
>>> >>>
>>> >>> I have rebuilt the resolver, then the framework, and I'm having this
>>> error:
>>> >>>
>>> >>> [ERROR]
>>> >>> /tmp/xx/framework/src/main/java/org/apache/felix/
>>> >>> framework/ResolveContextImpl.java:[44,8]
>>> >>> org.apache.felix.framework.ResolveContextImpl is not abstract and
>>> does not
>>> >>> override abstract method getSubstitutionWires(org.osgi.resource.Wiring)
>>> in
>>> >>> org.apache.felix.resolver.FelixResolveContext
>>> >>>
>>> >>> can someone please check this ?
>>> >>>
>>> >>> I just came across a NPE in the resolver using framework 5.6.1 and I
>>> would
>>> >>> like to check if I'm also having it with the latest resolver from the
>>> >>> trunk; thank you.
>>> >>>
>>> >>> best regards
>>> >>> /Pierre
>>> >>>
>>> >>>
>>> >>> On Mon, Feb 13, 2017 at 10:48 AM, Guillaume Nodet <gn...@apache.org>
>>> >>> wrote:
>>> >>>
>>> >>> > Great !
>>> >>> > Let me know if you need any help...
>>> >>> >
>>> >>> > Cheers,
>>> >>> > Guillaume
>>> >>> >
>>> >>> > 2017-02-10 12:53 GMT+01:00 Karl Pauls <ka...@gmail.com>:
>>> >>> >
>>> >>> > > I can do the release next week if you don't mind, as I was
>>> planning to
>>> >>> > > do a framework release anyhow (almost done with FELIX-5528 - just
>>> need
>>> >>> > > a bit more testing).
>>> >>> > >
>>> >>> > > regards,
>>> >>> > >
>>> >>> > > Karl
>>> >>> > >
>>> >>> > > On Fri, Feb 10, 2017 at 8:43 AM, Guillaume Nodet <
>>> gnodet@apache.org>
>>> >>> > > wrote:
>>> >>> > > > I'd like to get FELIX-5450 and FELIX-5514 out of the door, so
>>> unless
>>> >>> > > > someone volunteer to do the resolver 1.10.2 release, i'll give
>>> it a
>>> >>> > try
>>> >>> > > > next week.
>>> >>> > > >
>>> >>> > > > Cheers,
>>> >>> > > > Guillaume
>>> >>> > >
>>> >>> > >
>>> >>> > >
>>> >>> > > --
>>> >>> > > Karl Pauls
>>> >>> > > karlpauls@gmail.com
>>> >>> > >
>>> >>> >
>>> >>> >
>>> >>> >
>>> >>> > --
>>> >>> > ------------------------
>>> >>> > Guillaume Nodet
>>> >>> >
>>> >>>
>>> >
>>> >
>>> >
>>> > --
>>> > Karl Pauls
>>> > karlpauls@gmail.com
>>>
>>>
>>>
>>> --
>>> Karl Pauls
>>> karlpauls@gmail.com
>>>
>
>
>
> --
> Karl Pauls
> karlpauls@gmail.com
--
Karl Pauls
karlpauls@gmail.com
Re: [DISCUSS] Release resolver 1.10.2
Posted by Karl Pauls <ka...@gmail.com>.
Ok, can you or somebody else have a look at FELIX-5548 and see if that
is a blocker for a resolver release or no?
regards,
karl
On Tue, Feb 14, 2017 at 5:59 PM, Thomas Watson <tj...@gmail.com> wrote:
> Yes, the resolver is ready to release.
>
> Tom
>
> On Tue, Feb 14, 2017 at 9:37 AM, Karl Pauls <ka...@gmail.com> wrote:
>
>> Well, I guess I don't even have to make the method public - I'm just
>> going to copy it over to the framework if need be until we have a
>> better way.
>>
>> With that out of the way, do you think the resolver is good to go for a
>> release?
>>
>> regards,
>>
>> Karl
>>
>> On Tue, Feb 14, 2017 at 4:24 PM, Karl Pauls <ka...@gmail.com> wrote:
>> >> That is currently a private static method. If the Felix framework does
>> not
>> >> already have the substitution wire information available then we can
>> >> consider making this static method public so you can call it from your
>> >> FelixResolveContext implementation. But I think if you don't already
>> have
>> >> this information calculated for resolved wirings then you likely have a
>> bug
>> >> in require-bundle class loader delegation.
>> >
>> > Afaik, we don't have this info readily available as we keep track of
>> > this in a different way (I'll double-check with Richard).
>> >
>> > If not, I still would like to get a combined resolver and framework
>> > release done this week so assuming I make the method public and
>> > delegate to it from the framework do you think there is anything else
>> > that would prevent us from doing a resolver and framework release?
>> >
>> > regards,
>> >
>> > Karl
>> >
>> >> My hope is that in a future OSGi Resolver specification the
>> ResolveContext
>> >> API from OSGi will contain updates that make the FelixResolveContext
>> >> interface obsolete. For example, the proposed updates for the R7
>> resolver
>> >> already remove the need for the method
>> >> FelixResolveContext.getOndemandResources(Resource).
>> >>
>> >> Tom.
>> >>
>> >>
>> >> On Mon, Feb 13, 2017 at 10:13 AM, Pierre De Rop <pierre.derop@gmail.com
>> >
>> >> wrote:
>> >>
>> >>> Hi All,
>> >>>
>> >>> I also would like to do a test with the latest framework and resolver
>> from
>> >>> the trunk, but it looks like there is a compilation issue with the
>> >>> framework (trunk):
>> >>>
>> >>> I have rebuilt the resolver, then the framework, and I'm having this
>> error:
>> >>>
>> >>> [ERROR]
>> >>> /tmp/xx/framework/src/main/java/org/apache/felix/
>> >>> framework/ResolveContextImpl.java:[44,8]
>> >>> org.apache.felix.framework.ResolveContextImpl is not abstract and
>> does not
>> >>> override abstract method getSubstitutionWires(org.osgi.resource.Wiring)
>> in
>> >>> org.apache.felix.resolver.FelixResolveContext
>> >>>
>> >>> can someone please check this ?
>> >>>
>> >>> I just came across a NPE in the resolver using framework 5.6.1 and I
>> would
>> >>> like to check if I'm also having it with the latest resolver from the
>> >>> trunk; thank you.
>> >>>
>> >>> best regards
>> >>> /Pierre
>> >>>
>> >>>
>> >>> On Mon, Feb 13, 2017 at 10:48 AM, Guillaume Nodet <gn...@apache.org>
>> >>> wrote:
>> >>>
>> >>> > Great !
>> >>> > Let me know if you need any help...
>> >>> >
>> >>> > Cheers,
>> >>> > Guillaume
>> >>> >
>> >>> > 2017-02-10 12:53 GMT+01:00 Karl Pauls <ka...@gmail.com>:
>> >>> >
>> >>> > > I can do the release next week if you don't mind, as I was
>> planning to
>> >>> > > do a framework release anyhow (almost done with FELIX-5528 - just
>> need
>> >>> > > a bit more testing).
>> >>> > >
>> >>> > > regards,
>> >>> > >
>> >>> > > Karl
>> >>> > >
>> >>> > > On Fri, Feb 10, 2017 at 8:43 AM, Guillaume Nodet <
>> gnodet@apache.org>
>> >>> > > wrote:
>> >>> > > > I'd like to get FELIX-5450 and FELIX-5514 out of the door, so
>> unless
>> >>> > > > someone volunteer to do the resolver 1.10.2 release, i'll give
>> it a
>> >>> > try
>> >>> > > > next week.
>> >>> > > >
>> >>> > > > Cheers,
>> >>> > > > Guillaume
>> >>> > >
>> >>> > >
>> >>> > >
>> >>> > > --
>> >>> > > Karl Pauls
>> >>> > > karlpauls@gmail.com
>> >>> > >
>> >>> >
>> >>> >
>> >>> >
>> >>> > --
>> >>> > ------------------------
>> >>> > Guillaume Nodet
>> >>> >
>> >>>
>> >
>> >
>> >
>> > --
>> > Karl Pauls
>> > karlpauls@gmail.com
>>
>>
>>
>> --
>> Karl Pauls
>> karlpauls@gmail.com
>>
--
Karl Pauls
karlpauls@gmail.com
Re: [DISCUSS] Release resolver 1.10.2
Posted by Thomas Watson <tj...@gmail.com>.
Yes, the resolver is ready to release.
Tom
On Tue, Feb 14, 2017 at 9:37 AM, Karl Pauls <ka...@gmail.com> wrote:
> Well, I guess I don't even have to make the method public - I'm just
> going to copy it over to the framework if need be until we have a
> better way.
>
> With that out of the way, do you think the resolver is good to go for a
> release?
>
> regards,
>
> Karl
>
> On Tue, Feb 14, 2017 at 4:24 PM, Karl Pauls <ka...@gmail.com> wrote:
> >> That is currently a private static method. If the Felix framework does
> not
> >> already have the substitution wire information available then we can
> >> consider making this static method public so you can call it from your
> >> FelixResolveContext implementation. But I think if you don't already
> have
> >> this information calculated for resolved wirings then you likely have a
> bug
> >> in require-bundle class loader delegation.
> >
> > Afaik, we don't have this info readily available as we keep track of
> > this in a different way (I'll double-check with Richard).
> >
> > If not, I still would like to get a combined resolver and framework
> > release done this week so assuming I make the method public and
> > delegate to it from the framework do you think there is anything else
> > that would prevent us from doing a resolver and framework release?
> >
> > regards,
> >
> > Karl
> >
> >> My hope is that in a future OSGi Resolver specification the
> ResolveContext
> >> API from OSGi will contain updates that make the FelixResolveContext
> >> interface obsolete. For example, the proposed updates for the R7
> resolver
> >> already remove the need for the method
> >> FelixResolveContext.getOndemandResources(Resource).
> >>
> >> Tom.
> >>
> >>
> >> On Mon, Feb 13, 2017 at 10:13 AM, Pierre De Rop <pierre.derop@gmail.com
> >
> >> wrote:
> >>
> >>> Hi All,
> >>>
> >>> I also would like to do a test with the latest framework and resolver
> from
> >>> the trunk, but it looks like there is a compilation issue with the
> >>> framework (trunk):
> >>>
> >>> I have rebuilt the resolver, then the framework, and I'm having this
> error:
> >>>
> >>> [ERROR]
> >>> /tmp/xx/framework/src/main/java/org/apache/felix/
> >>> framework/ResolveContextImpl.java:[44,8]
> >>> org.apache.felix.framework.ResolveContextImpl is not abstract and
> does not
> >>> override abstract method getSubstitutionWires(org.osgi.resource.Wiring)
> in
> >>> org.apache.felix.resolver.FelixResolveContext
> >>>
> >>> can someone please check this ?
> >>>
> >>> I just came across a NPE in the resolver using framework 5.6.1 and I
> would
> >>> like to check if I'm also having it with the latest resolver from the
> >>> trunk; thank you.
> >>>
> >>> best regards
> >>> /Pierre
> >>>
> >>>
> >>> On Mon, Feb 13, 2017 at 10:48 AM, Guillaume Nodet <gn...@apache.org>
> >>> wrote:
> >>>
> >>> > Great !
> >>> > Let me know if you need any help...
> >>> >
> >>> > Cheers,
> >>> > Guillaume
> >>> >
> >>> > 2017-02-10 12:53 GMT+01:00 Karl Pauls <ka...@gmail.com>:
> >>> >
> >>> > > I can do the release next week if you don't mind, as I was
> planning to
> >>> > > do a framework release anyhow (almost done with FELIX-5528 - just
> need
> >>> > > a bit more testing).
> >>> > >
> >>> > > regards,
> >>> > >
> >>> > > Karl
> >>> > >
> >>> > > On Fri, Feb 10, 2017 at 8:43 AM, Guillaume Nodet <
> gnodet@apache.org>
> >>> > > wrote:
> >>> > > > I'd like to get FELIX-5450 and FELIX-5514 out of the door, so
> unless
> >>> > > > someone volunteer to do the resolver 1.10.2 release, i'll give
> it a
> >>> > try
> >>> > > > next week.
> >>> > > >
> >>> > > > Cheers,
> >>> > > > Guillaume
> >>> > >
> >>> > >
> >>> > >
> >>> > > --
> >>> > > Karl Pauls
> >>> > > karlpauls@gmail.com
> >>> > >
> >>> >
> >>> >
> >>> >
> >>> > --
> >>> > ------------------------
> >>> > Guillaume Nodet
> >>> >
> >>>
> >
> >
> >
> > --
> > Karl Pauls
> > karlpauls@gmail.com
>
>
>
> --
> Karl Pauls
> karlpauls@gmail.com
>
Re: [DISCUSS] Release resolver 1.10.2
Posted by Karl Pauls <ka...@gmail.com>.
Well, I guess I don't even have to make the method public - I'm just
going to copy it over to the framework if need be until we have a
better way.
With that out of the way, do you think the resolver is good to go for a release?
regards,
Karl
On Tue, Feb 14, 2017 at 4:24 PM, Karl Pauls <ka...@gmail.com> wrote:
>> That is currently a private static method. If the Felix framework does not
>> already have the substitution wire information available then we can
>> consider making this static method public so you can call it from your
>> FelixResolveContext implementation. But I think if you don't already have
>> this information calculated for resolved wirings then you likely have a bug
>> in require-bundle class loader delegation.
>
> Afaik, we don't have this info readily available as we keep track of
> this in a different way (I'll double-check with Richard).
>
> If not, I still would like to get a combined resolver and framework
> release done this week so assuming I make the method public and
> delegate to it from the framework do you think there is anything else
> that would prevent us from doing a resolver and framework release?
>
> regards,
>
> Karl
>
>> My hope is that in a future OSGi Resolver specification the ResolveContext
>> API from OSGi will contain updates that make the FelixResolveContext
>> interface obsolete. For example, the proposed updates for the R7 resolver
>> already remove the need for the method
>> FelixResolveContext.getOndemandResources(Resource).
>>
>> Tom.
>>
>>
>> On Mon, Feb 13, 2017 at 10:13 AM, Pierre De Rop <pi...@gmail.com>
>> wrote:
>>
>>> Hi All,
>>>
>>> I also would like to do a test with the latest framework and resolver from
>>> the trunk, but it looks like there is a compilation issue with the
>>> framework (trunk):
>>>
>>> I have rebuilt the resolver, then the framework, and I'm having this error:
>>>
>>> [ERROR]
>>> /tmp/xx/framework/src/main/java/org/apache/felix/
>>> framework/ResolveContextImpl.java:[44,8]
>>> org.apache.felix.framework.ResolveContextImpl is not abstract and does not
>>> override abstract method getSubstitutionWires(org.osgi.resource.Wiring) in
>>> org.apache.felix.resolver.FelixResolveContext
>>>
>>> can someone please check this ?
>>>
>>> I just came across a NPE in the resolver using framework 5.6.1 and I would
>>> like to check if I'm also having it with the latest resolver from the
>>> trunk; thank you.
>>>
>>> best regards
>>> /Pierre
>>>
>>>
>>> On Mon, Feb 13, 2017 at 10:48 AM, Guillaume Nodet <gn...@apache.org>
>>> wrote:
>>>
>>> > Great !
>>> > Let me know if you need any help...
>>> >
>>> > Cheers,
>>> > Guillaume
>>> >
>>> > 2017-02-10 12:53 GMT+01:00 Karl Pauls <ka...@gmail.com>:
>>> >
>>> > > I can do the release next week if you don't mind, as I was planning to
>>> > > do a framework release anyhow (almost done with FELIX-5528 - just need
>>> > > a bit more testing).
>>> > >
>>> > > regards,
>>> > >
>>> > > Karl
>>> > >
>>> > > On Fri, Feb 10, 2017 at 8:43 AM, Guillaume Nodet <gn...@apache.org>
>>> > > wrote:
>>> > > > I'd like to get FELIX-5450 and FELIX-5514 out of the door, so unless
>>> > > > someone volunteer to do the resolver 1.10.2 release, i'll give it a
>>> > try
>>> > > > next week.
>>> > > >
>>> > > > Cheers,
>>> > > > Guillaume
>>> > >
>>> > >
>>> > >
>>> > > --
>>> > > Karl Pauls
>>> > > karlpauls@gmail.com
>>> > >
>>> >
>>> >
>>> >
>>> > --
>>> > ------------------------
>>> > Guillaume Nodet
>>> >
>>>
>
>
>
> --
> Karl Pauls
> karlpauls@gmail.com
--
Karl Pauls
karlpauls@gmail.com
Re: [DISCUSS] Release resolver 1.10.2
Posted by Karl Pauls <ka...@gmail.com>.
> That is currently a private static method. If the Felix framework does not
> already have the substitution wire information available then we can
> consider making this static method public so you can call it from your
> FelixResolveContext implementation. But I think if you don't already have
> this information calculated for resolved wirings then you likely have a bug
> in require-bundle class loader delegation.
Afaik, we don't have this info readily available as we keep track of
this in a different way (I'll double-check with Richard).
If not, I still would like to get a combined resolver and framework
release done this week so assuming I make the method public and
delegate to it from the framework do you think there is anything else
that would prevent us from doing a resolver and framework release?
regards,
Karl
> My hope is that in a future OSGi Resolver specification the ResolveContext
> API from OSGi will contain updates that make the FelixResolveContext
> interface obsolete. For example, the proposed updates for the R7 resolver
> already remove the need for the method
> FelixResolveContext.getOndemandResources(Resource).
>
> Tom.
>
>
> On Mon, Feb 13, 2017 at 10:13 AM, Pierre De Rop <pi...@gmail.com>
> wrote:
>
>> Hi All,
>>
>> I also would like to do a test with the latest framework and resolver from
>> the trunk, but it looks like there is a compilation issue with the
>> framework (trunk):
>>
>> I have rebuilt the resolver, then the framework, and I'm having this error:
>>
>> [ERROR]
>> /tmp/xx/framework/src/main/java/org/apache/felix/
>> framework/ResolveContextImpl.java:[44,8]
>> org.apache.felix.framework.ResolveContextImpl is not abstract and does not
>> override abstract method getSubstitutionWires(org.osgi.resource.Wiring) in
>> org.apache.felix.resolver.FelixResolveContext
>>
>> can someone please check this ?
>>
>> I just came across a NPE in the resolver using framework 5.6.1 and I would
>> like to check if I'm also having it with the latest resolver from the
>> trunk; thank you.
>>
>> best regards
>> /Pierre
>>
>>
>> On Mon, Feb 13, 2017 at 10:48 AM, Guillaume Nodet <gn...@apache.org>
>> wrote:
>>
>> > Great !
>> > Let me know if you need any help...
>> >
>> > Cheers,
>> > Guillaume
>> >
>> > 2017-02-10 12:53 GMT+01:00 Karl Pauls <ka...@gmail.com>:
>> >
>> > > I can do the release next week if you don't mind, as I was planning to
>> > > do a framework release anyhow (almost done with FELIX-5528 - just need
>> > > a bit more testing).
>> > >
>> > > regards,
>> > >
>> > > Karl
>> > >
>> > > On Fri, Feb 10, 2017 at 8:43 AM, Guillaume Nodet <gn...@apache.org>
>> > > wrote:
>> > > > I'd like to get FELIX-5450 and FELIX-5514 out of the door, so unless
>> > > > someone volunteer to do the resolver 1.10.2 release, i'll give it a
>> > try
>> > > > next week.
>> > > >
>> > > > Cheers,
>> > > > Guillaume
>> > >
>> > >
>> > >
>> > > --
>> > > Karl Pauls
>> > > karlpauls@gmail.com
>> > >
>> >
>> >
>> >
>> > --
>> > ------------------------
>> > Guillaume Nodet
>> >
>>
--
Karl Pauls
karlpauls@gmail.com
Re: [DISCUSS] Release resolver 1.10.2
Posted by Thomas Watson <tj...@gmail.com>.
This is related to the fix for FELIX-5514.
The FelixResolveContext is an internal type (not something I consider real
API at this point). But its intention is to be used by the framework
(Felix and Equinox in particular) to allow the framework to do things
necessary to implement the OSGi framework easier. For example, discovering
related fragments when resolving a host bundle. I added a new method
getSubstitutionWires to make the discovery of substituted wires more
efficient for resolved bundle wirings from the framework. The reason I did
this was because the framework must already know what wires are substitute
wires for packages from the wiring. This information is necessary to
properly implement class loader delegation for require-bundle (section
3.13.1):
<spec>
Requiring bundles must get wired to all exported packages of all their
required bundles including exported packages from their attached fragments.
This means that any mandatory attributes on these exports must be ignored.
However, if a required bundle's exported package is substituted for an
imported package, then the requiring bundles must get wired to the same
exported package that the required bundle is wired to ensure class space
consistency.
</spec>
In the resolver I have implemented the algorithm for discovering the
substitution wires when there is no FelixResolveContext used. See
org.apache.felix.resolver.ResolverImpl.getSubstitutionWires(Wiring)
That is currently a private static method. If the Felix framework does not
already have the substitution wire information available then we can
consider making this static method public so you can call it from your
FelixResolveContext implementation. But I think if you don't already have
this information calculated for resolved wirings then you likely have a bug
in require-bundle class loader delegation.
My hope is that in a future OSGi Resolver specification the ResolveContext
API from OSGi will contain updates that make the FelixResolveContext
interface obsolete. For example, the proposed updates for the R7 resolver
already remove the need for the method
FelixResolveContext.getOndemandResources(Resource).
Tom.
On Mon, Feb 13, 2017 at 10:13 AM, Pierre De Rop <pi...@gmail.com>
wrote:
> Hi All,
>
> I also would like to do a test with the latest framework and resolver from
> the trunk, but it looks like there is a compilation issue with the
> framework (trunk):
>
> I have rebuilt the resolver, then the framework, and I'm having this error:
>
> [ERROR]
> /tmp/xx/framework/src/main/java/org/apache/felix/
> framework/ResolveContextImpl.java:[44,8]
> org.apache.felix.framework.ResolveContextImpl is not abstract and does not
> override abstract method getSubstitutionWires(org.osgi.resource.Wiring) in
> org.apache.felix.resolver.FelixResolveContext
>
> can someone please check this ?
>
> I just came across a NPE in the resolver using framework 5.6.1 and I would
> like to check if I'm also having it with the latest resolver from the
> trunk; thank you.
>
> best regards
> /Pierre
>
>
> On Mon, Feb 13, 2017 at 10:48 AM, Guillaume Nodet <gn...@apache.org>
> wrote:
>
> > Great !
> > Let me know if you need any help...
> >
> > Cheers,
> > Guillaume
> >
> > 2017-02-10 12:53 GMT+01:00 Karl Pauls <ka...@gmail.com>:
> >
> > > I can do the release next week if you don't mind, as I was planning to
> > > do a framework release anyhow (almost done with FELIX-5528 - just need
> > > a bit more testing).
> > >
> > > regards,
> > >
> > > Karl
> > >
> > > On Fri, Feb 10, 2017 at 8:43 AM, Guillaume Nodet <gn...@apache.org>
> > > wrote:
> > > > I'd like to get FELIX-5450 and FELIX-5514 out of the door, so unless
> > > > someone volunteer to do the resolver 1.10.2 release, i'll give it a
> > try
> > > > next week.
> > > >
> > > > Cheers,
> > > > Guillaume
> > >
> > >
> > >
> > > --
> > > Karl Pauls
> > > karlpauls@gmail.com
> > >
> >
> >
> >
> > --
> > ------------------------
> > Guillaume Nodet
> >
>
Re: [DISCUSS] Release resolver 1.10.2
Posted by Pierre De Rop <pi...@gmail.com>.
Hi All,
I also would like to do a test with the latest framework and resolver from
the trunk, but it looks like there is a compilation issue with the
framework (trunk):
I have rebuilt the resolver, then the framework, and I'm having this error:
[ERROR]
/tmp/xx/framework/src/main/java/org/apache/felix/framework/ResolveContextImpl.java:[44,8]
org.apache.felix.framework.ResolveContextImpl is not abstract and does not
override abstract method getSubstitutionWires(org.osgi.resource.Wiring) in
org.apache.felix.resolver.FelixResolveContext
can someone please check this ?
I just came across a NPE in the resolver using framework 5.6.1 and I would
like to check if I'm also having it with the latest resolver from the
trunk; thank you.
best regards
/Pierre
On Mon, Feb 13, 2017 at 10:48 AM, Guillaume Nodet <gn...@apache.org> wrote:
> Great !
> Let me know if you need any help...
>
> Cheers,
> Guillaume
>
> 2017-02-10 12:53 GMT+01:00 Karl Pauls <ka...@gmail.com>:
>
> > I can do the release next week if you don't mind, as I was planning to
> > do a framework release anyhow (almost done with FELIX-5528 - just need
> > a bit more testing).
> >
> > regards,
> >
> > Karl
> >
> > On Fri, Feb 10, 2017 at 8:43 AM, Guillaume Nodet <gn...@apache.org>
> > wrote:
> > > I'd like to get FELIX-5450 and FELIX-5514 out of the door, so unless
> > > someone volunteer to do the resolver 1.10.2 release, i'll give it a
> try
> > > next week.
> > >
> > > Cheers,
> > > Guillaume
> >
> >
> >
> > --
> > Karl Pauls
> > karlpauls@gmail.com
> >
>
>
>
> --
> ------------------------
> Guillaume Nodet
>
Re: [DISCUSS] Release resolver 1.10.2
Posted by Guillaume Nodet <gn...@apache.org>.
Great !
Let me know if you need any help...
Cheers,
Guillaume
2017-02-10 12:53 GMT+01:00 Karl Pauls <ka...@gmail.com>:
> I can do the release next week if you don't mind, as I was planning to
> do a framework release anyhow (almost done with FELIX-5528 - just need
> a bit more testing).
>
> regards,
>
> Karl
>
> On Fri, Feb 10, 2017 at 8:43 AM, Guillaume Nodet <gn...@apache.org>
> wrote:
> > I'd like to get FELIX-5450 and FELIX-5514 out of the door, so unless
> > someone volunteer to do the resolver 1.10.2 release, i'll give it a try
> > next week.
> >
> > Cheers,
> > Guillaume
>
>
>
> --
> Karl Pauls
> karlpauls@gmail.com
>
--
------------------------
Guillaume Nodet
Re: [DISCUSS] Release resolver 1.10.2
Posted by Karl Pauls <ka...@gmail.com>.
I can do the release next week if you don't mind, as I was planning to
do a framework release anyhow (almost done with FELIX-5528 - just need
a bit more testing).
regards,
Karl
On Fri, Feb 10, 2017 at 8:43 AM, Guillaume Nodet <gn...@apache.org> wrote:
> I'd like to get FELIX-5450 and FELIX-5514 out of the door, so unless
> someone volunteer to do the resolver 1.10.2 release, i'll give it a try
> next week.
>
> Cheers,
> Guillaume
--
Karl Pauls
karlpauls@gmail.com
Re: [DISCUSS] Release resolver 1.10.2
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1 for me.
Regards
JB
On Feb 10, 2017, 03:44, at 03:44, Guillaume Nodet <gn...@apache.org> wrote:
>I'd like to get FELIX-5450 and FELIX-5514 out of the door, so unless
>someone volunteer to do the resolver 1.10.2 release, i'll give it a
>try
>next week.
>
>Cheers,
>Guillaume