You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/12 21:46:13 UTC
[GitHub] [arrow] nevi-me opened a new pull request #8449: ARROW-7842: [Rust] [Parquet] Arrow list reader
nevi-me opened a new pull request #8449:
URL: https://github.com/apache/arrow/pull/8449
This is a port of #6770 to the parquet-writer branch.
We'll have more of a chance to test this reader,and ensure that we can roundtrip on list types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me closed pull request #8449: ARROW-7842: [Rust] [Parquet] Arrow list reader
Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #8449:
URL: https://github.com/apache/arrow/pull/8449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] carols10cents commented on a change in pull request #8449: ARROW-7842: [Rust] [Parquet] Arrow list reader
Posted by GitBox <gi...@apache.org>.
carols10cents commented on a change in pull request #8449:
URL: https://github.com/apache/arrow/pull/8449#discussion_r506601182
##########
File path: rust/parquet/src/arrow/arrow_writer.rs
##########
@@ -1049,9 +1049,7 @@ mod tests {
}
#[test]
- #[should_panic(
- expected = "Reading parquet list array into arrow is not supported yet!"
- )]
+ #[ignore = "Roundtrip failing, reason likely reader, not yet investigated"]
Review comment:
Looking at this now!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #8449: ARROW-7842: [Rust] [Parquet] Arrow list reader
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8449:
URL: https://github.com/apache/arrow/pull/8449#issuecomment-711067119
Merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8449: ARROW-7842: [Rust] [Parquet] Arrow list reader
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8449:
URL: https://github.com/apache/arrow/pull/8449#issuecomment-707364586
https://issues.apache.org/jira/browse/ARROW-7842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] carols10cents commented on a change in pull request #8449: ARROW-7842: [Rust] [Parquet] Arrow list reader
Posted by GitBox <gi...@apache.org>.
carols10cents commented on a change in pull request #8449:
URL: https://github.com/apache/arrow/pull/8449#discussion_r506725975
##########
File path: rust/parquet/src/arrow/arrow_writer.rs
##########
@@ -1049,9 +1049,7 @@ mod tests {
}
#[test]
- #[should_panic(
- expected = "Reading parquet list array into arrow is not supported yet!"
- )]
+ #[ignore = "Roundtrip failing, reason likely reader, not yet investigated"]
Review comment:
@nevi-me I [opened a PR on your repo](https://github.com/nevi-me/arrow/pull/6) with some further work -- feel free to cherry pick or whatever, but the tests aren't quite passing yet over there, just failing for a different reason ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on a change in pull request #8449: ARROW-7842: [Rust] [Parquet] Arrow list reader
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #8449:
URL: https://github.com/apache/arrow/pull/8449#discussion_r503551927
##########
File path: rust/parquet/src/arrow/arrow_writer.rs
##########
@@ -1049,9 +1049,7 @@ mod tests {
}
#[test]
- #[should_panic(
- expected = "Reading parquet list array into arrow is not supported yet!"
- )]
+ #[ignore = "Roundtrip failing, reason likely reader, not yet investigated"]
Review comment:
@carols10cents when you can, may you please help me out here on these 2 tests that I've ignored?
One needs a `LargeList` writer implementation, which I think you'd do better than me as you've done roundtrip for other Arrow types.
I've unignored `struct_single_column` as it's now passing, might be the null comparison commit that fixed it.
Thanks :smiley:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #8449: ARROW-7842: [Rust] [Parquet] Arrow list reader
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8449:
URL: https://github.com/apache/arrow/pull/8449#issuecomment-707364097
This doesn't need review, as I've addressed the questions that were in #6770. I'll wait for Carol's input before merging this.
CC @velvia @mcassels @maxburke as it was your original PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org